[MIG] sale_order_product_recommendation_secondary_unit: Migration to 12.0 #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
approved these changes
Nov 28, 2019
sergio-teruel
approved these changes
Nov 29, 2019
|
@chienandalu Can you increase coverage?? |
yajo
approved these changes
Nov 29, 2019
|
It's true that seeing the diff coverage, this module is essentially not tested. You can refactor tests in base module as I showed you in the past for inheriting that one only adding the secondary unit part. |
|
Sure, I'll do that |
chienandalu
force-pushed
the
12.0-mig-sale_order_product_recommendation_secondary_unit
branch
from
8b90985
to
2c98db4
Compare
|
Travis is red |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_product_recommendation_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_product_recommendation_secondary_unit/
chienandalu
force-pushed
the
12.0-mig-sale_order_product_recommendation_secondary_unit
branch
from
2c98db4
to
5787503
Compare
chienandalu
force-pushed
the
12.0-mig-sale_order_product_recommendation_secondary_unit
branch
from
5787503
to
ce1a3fc
Compare
pedrobaeza
approved these changes
Dec 2, 2019
|
/ocabot merge |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 2, 2019
|
Congratulations, your PR was merged at 063fa18. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT20511