Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] sale_order_line_description #1024

Closed
wants to merge 25 commits into from
Closed

[13.0][MIG] sale_order_line_description #1024

wants to merge 25 commits into from

Conversation

kongrattapong
Copy link
Contributor

@kongrattapong kongrattapong commented Dec 19, 2019 •
edited

Standard Migration

@oca-clabot
Copy link

Hey @kongrattapong, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

This was referenced Dec 19, 2019
Closed
Open
@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 19, 2019
marylla
marylla approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@marylla marylla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,
I made a functional review.
If a product has a sale description only this one is used to set the sale order line name. Otherwise, it is still the default code and product name.
So, LGTM! :)

rousseldenis
rousseldenis requested changes Jan 3, 2020
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Some changes

sale_order_line_description/models/__init__.py Outdated Show resolved Hide resolved
sale_order_line_description/tests/test_sale.py Outdated Show resolved Hide resolved
@kongrattapong kongrattapong force-pushed the 13.0-sale_order_line_description branch from b8058d7 to 3f6db3e Compare January 7, 2020 08:50
@kongrattapong kongrattapong force-pushed the 13.0-sale_order_line_description branch from 3f6db3e to 47f6c61 Compare February 6, 2020 09:51
tafaRU and others added 18 commits March 20, 2020 14:29
@tafaRU @kongrattapong
Rename module to sale_order_line_description
c2e8302
@kongrattapong
[IMP] Update code to new api
24ccd1d
@tafaRU @kongrattapong
Update po files due to change name of module
63bd96c
@kongrattapong
[IMP] sale_order_line_description: res_config => new api
8e8cdb5
@yvaucher @kongrattapong
Add bug tracker link on README.rst
e802a8e
@sysadminmatmoz @kongrattapong
Slovene translations added
548bf52
@tafaRU @kongrattapong
Get product aware of the language partner
d741523
@SimoRubi @kongrattapong
[MIG] sale_order_line_description: Migration to 10.0
6e56616
@SimoRubi @kongrattapong
[ADD] unit tests and minor changes
d9dce36
@oca-transbot @kongrattapong
OCA Transbot updated translations from Transifex
54e1178
@oca-travis @kongrattapong
[UPD] Update sale_order_line_description.pot
d2773a5
@tafaRU @kongrattapong
[IMP] sale_order_line_description: improve README file
248c76c
@cubells @kongrattapong
[MIG] sale_order_line_description: Migration to 11.0
1129a9f
@OCA-git-bot @kongrattapong
[UPD] README.rst
efde67e
@oca-travis @kongrattapong
[UPD] Update sale_order_line_description.pot
d47c1ce
@oca-transbot @kongrattapong
Update translation files
538c3e2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_line_description/
@mohamedhagag @kongrattapong
[12.0][MIG] sale_order_line_description: Migration to 12.0
774c2ac
@mohamedhagag @kongrattapong
squash! [12.0][MIG] sale_order_line_description: Migration to 12.0
e936dd1
oca-travis and others added 7 commits March 20, 2020 14:29
@oca-travis @kongrattapong
[UPD] Update sale_order_line_description.pot
a5f8093
@OCA-git-bot @kongrattapong
[UPD] README.rst
c273819
@oca-transbot @kongrattapong
Update translation files
3390c02 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/
@liweijie0812 @kongrattapong
Added translation using Weblate (Chinese (Simplified))
638fd0d
@liweijie0812 @kongrattapong
Translated using Weblate (Chinese (Simplified))
fa8a76e 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_line_description
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_line_description/zh_CN/
@kongrattapong
[IMP] sale_order_line_description: black, isort
2ff3938
@kongrattapong
[MIG] sale_order_line_description: Migration to 13.0
39cb536
@kongrattapong kongrattapong force-pushed the 13.0-sale_order_line_description branch from 47f6c61 to 39cb536 Compare March 20, 2020 07:30
danimv5
danimv5 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@danimv5 danimv5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review! LGTM

@marylla
Copy link
Contributor

marylla commented Sep 25, 2020

@rousseldenis Everything ok now? Can we merge this?

eduardgm
eduardgm approved these changes Sep 29, 2020
View reviewed changes
Copy link

@eduardgm eduardgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's all okay, LGTM 👍🏻

@maitaoriana
Copy link
Contributor

Hi @kongrattapong , Could I help with the last changes? I think that the last change would be remove the licencies from init files

@maitaoriana maitaoriana mentioned this pull request Oct 8, 2020
Merged
@maitaoriana
Copy link
Contributor

Hi @rousseldenis , the changes requested by you were made in this PR: #1282. Could you review it please?

@rousseldenis
Copy link
Sponsor Contributor

Hi @rousseldenis , the changes requested by you were made in this PR: #1282. Could you review it please?

So, we can close this one ?

@maitaoriana
Copy link
Contributor

maitaoriana commented Dec 1, 2020 •
edited

Hi @rousseldenis, I think that this PR could close because it has been inactive for a long time. Also in the PR #1282 I make a cherry pick of the commits of this PR. Thanks

@HaraldPanten
Copy link
Contributor

@rousseldenis do you agree if we close this one as it has been superseded by #1024 ?

@rousseldenis
Copy link
Sponsor Contributor

@rousseldenis do you agree if we close this one as it has been superseded by #1024 ?

You have super powers, so you can do it. 😃 If an old PR has no activity and no answer from author, don't hesitate to supersedes.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 10, 2022
@github-actions github-actions bot closed this Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis requested changes

@atchuthan atchuthan atchuthan approved these changes

@marylla marylla marylla approved these changes

@eduardgm eduardgm eduardgm approved these changes

@danimv5 danimv5 danimv5 approved these changes

Assignees
No one assigned
Labels
migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet