[13.0][MIG] sale_order_type #1025

kongrattapong · 2019-12-19T05:08:01Z

Ready to review

oca-clabot · 2019-12-19T05:08:03Z

Hey @kongrattapong, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Carlos Sánchez Cifuentes csanchez@grupovermon.com (no github login found)
Pierre Faniel pierre@niboo.be (no github login found)

Appreciation of efforts,
OCA CLAbot

marylla

Hi there,
I made a functional review. I could create a new sale order type with a different sequence, payment term, shipping policy, and so on.
Quotations were created according to the chosen type. So, LGTM. :)

rousseldenis

Code review

sale_order_type/models/sale.py

rousseldenis

Code review

OCA-git-bot · 2020-01-06T11:19:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sergio-teruel · 2020-03-02T17:07:57Z

This module contains more than one module (sale_order_line_description)
@kongrattapong Can you do the PR only with sale_order_type module?
ping @rousseldenis

dreispt · 2020-03-10T10:13:03Z

/ocabot merge

OCA-git-bot · 2020-03-10T10:13:18Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1025-by-dreispt-bump-no, awaiting test results.

Signed-off-by dreispt

pedrobaeza · 2020-03-10T10:14:40Z

Aborting because there are changes of other modules.

pedrobaeza

Remove the changes in sale_order_line_description module.

pedrobaeza · 2020-03-10T10:18:39Z

@dreispt please always check the full thread, not only the approvals. Some people thinks that putting request changes is very hard and only comment in the thread, but this is not correct to be merged as is.

kongrattapong · 2020-03-20T07:15:48Z

This module contains more than one module (sale_order_line_description)
@kongrattapong Can you do the PR only with sale_order_type module?
ping @rousseldenis

Thank for review I Removed.

[UPD] Update sale_order_type.pot

The other one is a fake one that is dangling

If a contact doesn't have sale type, we use the commercial partner one.

Currently translated at 100.0% (31 of 31 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_type/es/

Currently translated at 100.0% (31 of 31 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_type/zh_CN/

Currently translated at 83.9% (26 of 31 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_type/it/

In the original onchange method by odoo, this return an dict with values(warnings and domians), but when inherit this method in this module they not return this dict. Because of this the alert setting in the partner was no working.

* Switch onchange on the main field to computed writable fields * Record rule is not up to v13 * Added migration script for record rule * Proper payment term field name in invoice * Realign tests

pedrobaeza · 2020-04-06T10:31:14Z

/ocabot merge

OCA-git-bot · 2020-04-06T10:31:32Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1025-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2020-04-06T10:37:12Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1025-by-pedrobaeza-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2020-04-06T11:25:51Z

Let's merge it manually as it's not possible to use bot.

kongrattapong changed the title ~~13.0 mig sale order type~~ [13.0][MIG] sale_order_type Dec 19, 2019

kongrattapong force-pushed the 13.0-mig-sale_order_type branch from 1325133 to 2c1bb1b Compare December 19, 2019 07:02

This was referenced Dec 19, 2019

Migration to version 13.0 #942

Closed

[13.0][MIG] sale_order_type ecosoft-odoo/kanban#97

Open

kongrattapong force-pushed the 13.0-mig-sale_order_type branch from 2c1bb1b to e41962b Compare December 19, 2019 07:50

pedrobaeza added this to the 13.0 milestone Dec 19, 2019

marylla approved these changes Jan 3, 2020

View reviewed changes

rousseldenis added migration needs review labels Jan 3, 2020

rousseldenis requested changes Jan 3, 2020

View reviewed changes

sale_order_type/models/sale.py Outdated Show resolved Hide resolved

kongrattapong force-pushed the 13.0-mig-sale_order_type branch from e41962b to a3ef053 Compare January 6, 2020 10:39

rousseldenis approved these changes Jan 6, 2020

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 6, 2020

OCA-git-bot added a commit that referenced this pull request Mar 10, 2020

Merge PR #1025 into 13.0

8d1c1f2

Signed-off-by dreispt

pedrobaeza requested changes Mar 10, 2020

View reviewed changes

OCA-git-bot removed approved ready to merge labels Mar 10, 2020

kongrattapong force-pushed the 13.0-mig-sale_order_type branch 4 times, most recently from b90b67b to 09c93d1 Compare March 20, 2020 07:14

oca-transbot and others added 20 commits April 6, 2020 12:10

OCA Transbot updated translations from Transifex

918c230

[MIG] sale_order_type: Migrated to 10.0

ed24ce1

OCA Transbot updated translations from Transifex

bc9a7d0

[MIG] sale_order_type: Migration to 11.0

a8bd76e

[FIX] sale_order_type: avoid error on invoices if user is only acountant

8b9aa6f

remove obsolete .pot files [ci skip]

5680200

[UPD] Update sale_order_type.pot

7e2fedf

[UPD] Update sale_order_type.pot

[FIX] sale_order_type: Correct parent menu

0690d9d

The other one is a fake one that is dangling

[UPD] Update sale_order_type.pot

3ffe96e

[IMP] sale_order_type: Use commercial partner sale type as fallback

0682331

If a contact doesn't have sale type, we use the commercial partner one.

[IMP] sale_order_type: New README style

7555806

Translated using Weblate (Spanish)

1578edc

Currently translated at 100.0% (31 of 31 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_order_type/es/

[IMP] sale_order_type: Use 'Sales Order' config submenu (OCA#720)

76211f8

MIG sale_order_type

c15d263

Translated using Weblate (Italian)

282c1cc

Currently translated at 83.9% (26 of 31 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_type Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_type/it/

[IMP] sale_order_type: black, isort

655ae5f

[MIG] sale_order_type: Migration to 13.0

4a69446

[FIX+IMP] sale_order_type: New computed writable + migration fixes

8e40947

* Switch onchange on the main field to computed writable fields * Record rule is not up to v13 * Added migration script for record rule * Proper payment term field name in invoice * Realign tests

pedrobaeza force-pushed the 13.0-mig-sale_order_type branch from 811b6fc to 8e40947 Compare April 6, 2020 10:10

OCA-git-bot added a commit that referenced this pull request Apr 6, 2020

Merge PR #1025 into 13.0

3b73042

Signed-off-by pedrobaeza

OCA-git-bot added the bot is merging ⏳ label Apr 6, 2020

OCA-git-bot removed the bot is merging ⏳ label Apr 6, 2020

pedrobaeza merged commit 0d99448 into OCA:13.0 Apr 6, 2020

pedrobaeza mentioned this pull request Apr 6, 2020

pre-commit prettier environment fails when prebuilding node (13.12.0) OCA/maintainer-quality-tools#661

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][MIG] sale_order_type #1025

[13.0][MIG] sale_order_type #1025

kongrattapong commented Dec 19, 2019 •

edited

oca-clabot commented Dec 19, 2019

marylla left a comment

rousseldenis left a comment

rousseldenis left a comment

OCA-git-bot commented Jan 6, 2020

sergio-teruel commented Mar 2, 2020

dreispt commented Mar 10, 2020

OCA-git-bot commented Mar 10, 2020

pedrobaeza commented Mar 10, 2020

pedrobaeza left a comment

pedrobaeza commented Mar 10, 2020

kongrattapong commented Mar 20, 2020

pedrobaeza commented Apr 6, 2020

OCA-git-bot commented Apr 6, 2020

OCA-git-bot commented Apr 6, 2020

pedrobaeza commented Apr 6, 2020

[13.0][MIG] sale_order_type #1025

[13.0][MIG] sale_order_type #1025

Conversation

kongrattapong commented Dec 19, 2019 • edited

oca-clabot commented Dec 19, 2019

marylla left a comment

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 6, 2020

sergio-teruel commented Mar 2, 2020

dreispt commented Mar 10, 2020

OCA-git-bot commented Mar 10, 2020

pedrobaeza commented Mar 10, 2020

pedrobaeza left a comment

Choose a reason for hiding this comment

pedrobaeza commented Mar 10, 2020

kongrattapong commented Mar 20, 2020

pedrobaeza commented Apr 6, 2020

OCA-git-bot commented Apr 6, 2020

OCA-git-bot commented Apr 6, 2020

pedrobaeza commented Apr 6, 2020

kongrattapong commented Dec 19, 2019 •

edited