Recompute shipped value on each procurement state change #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
force-pushed
the
8.0-fix-is_shipped
branch
from
7d7b7d0
to
1ed06d0
Compare
|
module version update is not strictly necessary as the changes do not mandate an update of the module. is there a test in the module exercising this new bit of code? |
|
@gurneyalex The test is there and waiting on a odoo bug 😢 |
| current_proc = proc | ||
| while (not current_proc.sale_line_id and | ||
| current_proc.move_dest_id): | ||
| current_proc = proc.move_dest_id.procurement_id |
There was a problem hiding this comment.
🐛 infinite ➿
s/proc.move/current_proc.move/
|
yvaucher: and the test was 🍏 with the infinite loop inside? This is suspicious... |
|
@gurneyalex There is no test for this, the test is in another PR which should work now and make this PR obsolete: #83 |
|
Thus I close this PR as #83 resolves this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.