[13.0][IMP] sale_by_packaging can be sold #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDu
force-pushed
the
imp-can-be-sold-product-packaging
branch
from
b6dc7dc
to
cc999ea
Compare
simahawk
reviewed
Dec 16, 2020
TDu
force-pushed
the
imp-can-be-sold-product-packaging
branch
from
cc999ea
to
edb553f
Compare
|
I have added a unit test. |
TDu
force-pushed
the
imp-can-be-sold-product-packaging
branch
from
90d5e4e
to
b2263c8
Compare
simahawk
requested changes
Jan 11, 2021
rousseldenis
requested changes
Jan 12, 2021
| @@ -18,3 +19,8 @@ class ProductPackaging(models.Model): | |||
| "When the user will put 3 as quantity, the system can force the " | |||
| "quantity to the superior unit (5 for this example).", | |||
| ) | |||
|
|
|||
| @api.depends("packaging_type_id") | |||
There was a problem hiding this comment.
Suggested change
| @api.depends("packaging_type_id") | |
| @api.depends("packaging_type_id.can_be_sold") |
There was a problem hiding this comment.
@rousseldenis I think this is done on purpose: you don't want this value to change if the type changes its value.
There was a problem hiding this comment.
Yes that is how it was requested.
You get the default "can_be_sold" value when selecting a packaging_type. But afterwards you can change it on the product.packaging.
simahawk
approved these changes
Jan 13, 2021
|
@TDu pls squash :) |
This change allows to be more specific on which product.packaging can be sold or not. By default the value from the product.packaging.type is used. But it is editable afterwards, with this change.
TDu
force-pushed
the
imp-can-be-sold-product-packaging
branch
from
21b4036
to
7025c74
Compare
|
@simahawk Squash done |
|
@rousseldenis piiiing :) |
rousseldenis
approved these changes
Jan 19, 2021
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at de30cab. Thanks a lot for contributing to OCA. ❤️ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to be more specific on which product.packaging can be
sold or not.
By default the value from the product.packaging.type is used. But it is
editable afterwards, with this change.