Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][ADD] sale_pwa_cache #1519

Closed
wants to merge 20 commits into from
Closed

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Mar 19, 2021

@Tardo Tardo marked this pull request as draft March 19, 2021 20:36
@Tardo Tardo mentioned this pull request Apr 1, 2021
@Tardo Tardo force-pushed the 13.0-add-sale_pwa_cache branch 3 times, most recently from 47bc4e3 to fa789d7 Compare April 15, 2021 17:43
@pedrobaeza pedrobaeza force-pushed the 13.0-add-sale_pwa_cache branch 7 times, most recently from 92463dc to 30f1192 Compare April 26, 2021 18:36
@Tardo Tardo force-pushed the 13.0-add-sale_pwa_cache branch 3 times, most recently from da83644 to 155948c Compare June 7, 2021 19:06
@Tardo Tardo force-pushed the 13.0-add-sale_pwa_cache branch 2 times, most recently from d63ea1c to 14473b7 Compare June 17, 2021 10:21
context="{'company_id': parent.company_id}"
class="mb-2"
options="{'no_open': True, 'no_create': True, 'no_edit': True}"
domain="[['category_id', '=', uom_category_id]]"
Copy link
Member

@pedrobaeza pedrobaeza Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to force this domain, but use the standard one:

https://github.com/odoo/odoo/blob/c76454f325a52ba4bb49d9dae9f760046eb39ebd/addons/sale/models/sale.py#L1280

and add product_uom_category_id field.

}"
context="{'company_id': parent.company_id}"
class="mb-2"
options="{'no_open': True, 'no_create': True, 'no_edit': True}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add groups="uom.group_uom"

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 26, 2023
@github-actions github-actions bot closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants