Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_order_line_description: res_config => new api #158

Merged
merged 3 commits into from May 21, 2015

Conversation

Daniel-CA
Copy link
Contributor

res_config to new api

),
}
group_use_product_description_per_so_line = fields.Boolean(
"""Allow using only the product sale description on the sales
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put triple quotas here, and change translations template according it.

@Daniel-CA
Copy link
Contributor Author

Done!

#. module: sale_order_line_description
#: help:sale.config.settings,group_use_product_description_per_so_line:0
msgid "Allows you to use only product sale description on the\n"
" sales order line."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the old translation. The new mustn't contain spaces.

@Daniel-CA
Copy link
Contributor Author

Done, I forgot the update

@pedrobaeza
Copy link
Member

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.35% when pulling 07d978a on Daniel-CA:sale_order_line_description into b1aef03 on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.35% when pulling 07d978a on Daniel-CA:sale_order_line_description into b1aef03 on OCA:8.0.

@eLBati
Copy link
Member

eLBati commented May 21, 2015

thanks 👍

@tafaRU
Copy link
Member

tafaRU commented May 21, 2015

👍

tafaRU added a commit that referenced this pull request May 21, 2015
[IMP] sale_order_line_description: res_config => new api
@tafaRU tafaRU merged commit b97f987 into OCA:8.0 May 21, 2015
@Daniel-CA Daniel-CA deleted the sale_order_line_description branch May 21, 2015 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants