8.0 add support for rental #164
Conversation
…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".
Add list of limitations in the module description.
Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental
This bug was very annoying because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)
…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.
Add a link to the screencast in the module description
| ############################################################################## | ||
|
|
||
| from . import rental | ||
| from . import wizard |
There was a problem hiding this comment.
line 1 to 22 are not useful, just import no license mandatory, no explicit encoding, just ascii used
It's just a suggestion, you may keep as it if you want
1 similar comment
|
|
||
| In the menu *Warehouse > Configuration > Warehouses*, on the form view | ||
| of the warehouse, in the *Technical Information* tab, you will see two | ||
| additionnal stock locations: *Rental In* (stock of products to rent) and |
There was a problem hiding this comment.
Replace "additionnal" with "additional".
| @@ -27,6 +27,8 @@ virtualenv: | |||
|
|
|||
| install: | |||
| - git clone https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools | |||
| - git clone https://github.com/OCA/account-closing.git ${HOME}/account-closing | |||
| - git clone https://github.com/OCA/server-tools.git ${HOME}/server-tools | |||
There was a problem hiding this comment.
Those repositories should be added to oca_dependencies.txt and don't need to be added here, I think.
| #: code:addons/sale_rental/rental.py:59 | ||
| #, python-format | ||
| msgid "The rental product '%s' must have the option ''Must Have Start and End Dates' checked." | ||
| msgstr "The rental product '%s' must have the option ''Must Have Start and End Dates' checked." |
Fix translated string in code
|
Thanks @alexis-via 👍 |
| 'Wrong underlying model, should be product.product' | ||
| hw_product = self.env['product.product'].browse( | ||
| self.env.context['active_id']) | ||
| return _('RENT-%s') % hw_product.default_code |
There was a problem hiding this comment.
The stockable product that is used as a reference to create the service rental could have the default code set as empty. In that case the current code sets "RENT-false". I suggest to add the default code for the created rental service only if the associated product has a default_code set.
There was a problem hiding this comment.
I can see that the default code is a required field in the wizard. Why is that, if the default_code field is not a required field at all in the product? What if the original product has no default code?
Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field
|
@jbeficent I took into account your remarks. It deserves a 👍 :) |
|
@jbeficent Any other remarks ? We need a second positive review to merge this. |
|
I have some work in progress on tests and spanish translations. Will submit a separate PR. Another remark, I tested with module 'stock_quant_manual_assign' from @pedrobaeza and it allows you to manually select the lot/serial that you want to rent. This is really a value added function, in cases where you rent serialized equipment. |
|
+1 to merge. Good work @alexis-via |
|
good work 👍 |
8.0 add support for rental
These rental modules were initially developed on https://code.launchpad.net/openerp-rental
So it's now time to move to github/OCA