[WIP][DO NOT MERGE][13.0] Add sale_warehouse_calendar #1696

mmequignon · 2021-08-13T12:37:32Z

⚠️
Work in progress
Needs fixing
Do not merge

Computes sale order lead times with respect to to Warehouse calendar

OCA-git-bot · 2021-08-13T12:37:35Z

Hi @mmequignon! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

sale_warehouse_calendar/models/sale_order_line.py

sale_warehouse_calendar/tests/test_sale_order_dates.py

sale_warehouse_calendar/models/sale_order_line.py

sebalix

Pre-approving, one small comment

sebalix · 2021-09-16T12:33:11Z

.travis.yml

    - stage: test
      env:
-        - TESTS="1" ODOO_REPO="OCA/OCB"
+        - TESTS="1" ODOO_REPO="OCA/OCB" EXCLUDE="sale_warehouse_calendar"


Can you add a comment about the conflicting module?

done in the doc.

are you sure you are running your tests w/ these settings?

jbaudoux

There is likely an error in the computation of the date planned

sale_warehouse_calendar/models/sale_order_line.py

sale_warehouse_calendar/readme/DESCRIPTION.rst

sale_warehouse_calendar/tests/test_sale_order_dates.py

sale_warehouse_calendar/__manifest__.py

jbaudoux

Thanks for the comments. Code is very understandable

simahawk

check the tests pls

simahawk · 2021-09-21T07:25:48Z

.travis.yml

    - stage: test
      env:
-        - TESTS="1" ODOO_REPO="OCA/OCB"
+        - TESTS="1" ODOO_REPO="OCA/OCB" EXCLUDE="sale_warehouse_calendar"


are you sure you are running your tests w/ these settings?

sale_warehouse_calendar/models/sale_order_line.py

DDMRP is broken when a calendar is set on the warehouse. We need to be able to set a calendar whithout breaking DDMRP. Remove this commit when DDMRP is fixed.

mmequignon · 2021-10-14T09:43:54Z

Do not merge this (see the last commit description)

jbaudoux

This last commit is not fixing the hours issue in the right way.
If calendar plan_day is hours aware, then it should be fixed just before the call to that method.

jbaudoux · 2021-10-29T08:54:40Z

sale_warehouse_calendar/models/sale_order_line.py

@@ -41,6 +41,11 @@ def _sale_warehouse_calendar_expected_date(self, expected_date):
            )
            # add back the security lead
            expected_date += td_security_lead
+            # This should be the delivery date.
+            # It is up to the carrier to determine the hour with the customer
+            expected_date = expected_date.replace(


This is not TZ compliant and won't work for countries in UTC-X.
I would not change the hours here. If this is necessary in a later calendar computation, it is there that it should be fixed.

jbaudoux · 2021-10-29T08:56:15Z

sale_warehouse_calendar/models/sale_order_line.py

                workload_days, date_planned, compute_leaves=True
            )
+            res["date_planned"] = date_planned.replace(


Same remark as above

github-actions · 2023-08-27T12:19:36Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

sebalix reviewed Aug 19, 2021

View reviewed changes

sale_warehouse_calendar/models/sale_order_line.py Outdated Show resolved Hide resolved

sebalix reviewed Aug 19, 2021

View reviewed changes

sale_warehouse_calendar/models/sale_order_line.py Outdated Show resolved Hide resolved

sebalix reviewed Aug 19, 2021

View reviewed changes

sale_warehouse_calendar/models/sale_order_line.py Outdated Show resolved Hide resolved

mmequignon force-pushed the 13.0-add-sale-warehouse-calendar branch 4 times, most recently from cd70f9a to 03c0210 Compare September 13, 2021 11:34

mmequignon changed the title ~~[WIP][13.0] add sale warehouse calendar~~ [13.0] add sale warehouse calendar Sep 13, 2021

simahawk requested changes Sep 13, 2021

View reviewed changes

sebalix approved these changes Sep 16, 2021

View reviewed changes

jbaudoux suggested changes Sep 17, 2021

View reviewed changes

mmequignon force-pushed the 13.0-add-sale-warehouse-calendar branch 2 times, most recently from 18f61c7 to f320d38 Compare September 20, 2021 14:27

simahawk changed the title ~~[13.0] add sale warehouse calendar~~ [13.0] Add sale_warehouse_calendar Sep 21, 2021

jbaudoux approved these changes Sep 21, 2021

View reviewed changes

simahawk requested changes Sep 21, 2021

View reviewed changes

mmequignon force-pushed the 13.0-add-sale-warehouse-calendar branch from f320d38 to c571fdb Compare September 21, 2021 11:22

[13.0] Add sale_warehouse_calendar

dc4df08

mmequignon force-pushed the 13.0-add-sale-warehouse-calendar branch from c571fdb to dc4df08 Compare September 23, 2021 13:15

mmequignon mentioned this pull request Oct 7, 2021

[14.0][ADD] sale_delivery_date #1736

Merged

TO REMOVE: add temporary calendar field on warehouse

5b0b93a

DDMRP is broken when a calendar is set on the warehouse. We need to be able to set a calendar whithout breaking DDMRP. Remove this commit when DDMRP is fixed.

simahawk added needs fixing work in progress labels Oct 14, 2021

mmequignon changed the title ~~[13.0] Add sale_warehouse_calendar~~ [WIP][DO NOT MERGE][13.0] Add sale_warehouse_calendar Oct 14, 2021

fixup! [13.0] Add sale_warehouse_calendar

ab6c7ba

jbaudoux suggested changes Oct 29, 2021

View reviewed changes

sebalix mentioned this pull request Feb 1, 2022

[14.0][TMP] fix to resolve calendar conflict with DDMRP #1892

Closed

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 27, 2023

github-actions bot closed this Oct 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP][DO NOT MERGE][13.0] Add sale_warehouse_calendar #1696

[WIP][DO NOT MERGE][13.0] Add sale_warehouse_calendar #1696

mmequignon commented Aug 13, 2021 •

edited

Loading

OCA-git-bot commented Aug 13, 2021

sebalix left a comment

sebalix Sep 16, 2021

mmequignon Sep 16, 2021

simahawk Sep 21, 2021 •

edited

Loading

jbaudoux left a comment

jbaudoux left a comment

simahawk left a comment

simahawk Sep 21, 2021 •

edited

Loading

mmequignon commented Oct 14, 2021

jbaudoux left a comment

jbaudoux Oct 29, 2021

jbaudoux Oct 29, 2021

github-actions bot commented Aug 27, 2023

[WIP][DO NOT MERGE][13.0] Add sale_warehouse_calendar #1696

[WIP][DO NOT MERGE][13.0] Add sale_warehouse_calendar #1696

Conversation

mmequignon commented Aug 13, 2021 • edited Loading

OCA-git-bot commented Aug 13, 2021

sebalix left a comment

Choose a reason for hiding this comment

sebalix Sep 16, 2021

Choose a reason for hiding this comment

mmequignon Sep 16, 2021

Choose a reason for hiding this comment

simahawk Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

simahawk Sep 21, 2021 • edited Loading

Choose a reason for hiding this comment

mmequignon commented Oct 14, 2021

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux Oct 29, 2021

Choose a reason for hiding this comment

jbaudoux Oct 29, 2021

Choose a reason for hiding this comment

github-actions bot commented Aug 27, 2023

mmequignon commented Aug 13, 2021 •

edited

Loading

simahawk Sep 21, 2021 •

edited

Loading

simahawk Sep 21, 2021 •

edited

Loading