-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sale_order_line_price_history : add color indication #1834
[IMP] sale_order_line_price_history : add color indication #1834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
I like this kind of addition.
Could you add some functional information about this in the /readme section and improve this PR title (as 'color indication' yes, but related to ?) ?
Thanks
Isn't better to disable the icon if no purchases? Clicking on it will lead to an empty list, so let's not allow to click it at all. |
I would say that having an icon or not mixed on lines could be UX deficient, no ? |
Disabling it is not hiding it |
Anyways, hiding it is another approach of UX, not UX deficient. Odoo does it continuously across modules. |
…g on whether the customer has already purchased the product
Thanks @v-garcies it's working well for me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @v-garcies 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments and don't add yourself as author, as this is a minimum improvement
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This commit adds a color indication to the clock icon in sales order lines :