Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_order_line_price_history : add color indication #1834

Closed

Conversation

v-garcies
Copy link

@v-garcies v-garcies commented Dec 22, 2021

This commit adds a color indication to the clock icon in sales order lines :

  • black if the customer has never purchased the item
  • blue if the customer has already purchased the item

Capture d’écran 2021-12-22 à 11 18 09

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

I like this kind of addition.

Could you add some functional information about this in the /readme section and improve this PR title (as 'color indication' yes, but related to ?) ?

Thanks

sale_order_line_price_history/models/sale_order_line.py Outdated Show resolved Hide resolved
@pedrobaeza
Copy link
Member

Isn't better to disable the icon if no purchases? Clicking on it will lead to an empty list, so let's not allow to click it at all.

@rousseldenis
Copy link
Sponsor Contributor

Isn't better to disable the icon if no purchases? Clicking on it will lead to an empty list, so let's not allow to click it at all.

I would say that having an icon or not mixed on lines could be UX deficient, no ?

@pedrobaeza
Copy link
Member

Disabling it is not hiding it

@pedrobaeza
Copy link
Member

Anyways, hiding it is another approach of UX, not UX deficient. Odoo does it continuously across modules.

…g on whether the customer has already purchased the product
@fdesmottes
Copy link

Thanks @v-garcies it's working well for me 👍

Copy link

@ajaniszewska-dev ajaniszewska-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

@fdesmottes fdesmottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-garcies 👍

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments and don't add yourself as author, as this is a minimum improvement

Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@github-actions github-actions bot closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement migration stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants