Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_stock_picking_blocking #1888

Merged
merged 25 commits into from
Jun 9, 2022
Merged

[15.0][MIG] sale_stock_picking_blocking #1888

merged 25 commits into from
Jun 9, 2022

Conversation

kirca
Copy link
Contributor

@kirca kirca commented Jan 26, 2022

No description provided.

@kirca kirca mentioned this pull request Jan 26, 2022
Open
@rousseldenis rousseldenis added this to the 15.0 milestone Feb 3, 2022
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_stock_picking_blocking

rousseldenis
rousseldenis requested changes Feb 3, 2022
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirca Thanks for your contribution. Could you attend comments ?

I advise you to follow for the next time https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#technical-method-to-migrate-a-module-from-140-to-150-branch

And especially the Full process part. Thanks

sale_stock_picking_blocking/tests/test_sale_stock_picking_blocking.py Outdated Show resolved Hide resolved
sale_stock_picking_blocking/models/sale_order.py Show resolved Hide resolved
@kirca kirca force-pushed the 15.0-mig-sale_stock_picking_blocking branch from f76d2c2 to 1463a1f Compare February 3, 2022 08:40
@kirca
Copy link
Contributor Author

kirca commented Feb 3, 2022

Thanks @rousseldenis I've added the changes.

I did follow to migration guideline however and they do not seem to appear in the pre-commit checks.

@rousseldenis
Copy link
Sponsor Contributor

Thanks @rousseldenis I've added the changes.

I did follow to migration guideline however and they do not seem to appear in the pre-commit checks.

It's about these lines that should be done before the code migration itself:

image

@JuanyDForgeflow
Copy link

@kirca Do you plan to continue this?

@kirca kirca force-pushed the 15.0-mig-sale_stock_picking_blocking branch from 1463a1f to 946657d Compare May 17, 2022 12:14
AaronHForgeFlow and others added 19 commits May 17, 2022 14:36
@AaronHForgeFlow @kirca
[FIX]module rename. sale_delivery_block -> sale_stock_picking_blocking
d89c4f3
@oca-travis @kirca
[UPD] Update sale_stock_picking_blocking.pot
470a2d8
@MiquelRForgeFlow @kirca
[MIG] sale_stock_picking_blocking: Migration to 11.0
c1218a3
@OCA-git-bot @kirca
[UPD] README.rst
ce963d1
@MiquelRForgeFlow @kirca
[FIX] sale_stock_picking_blocking: view error
3670f32
@oca-travis @kirca
[UPD] Update sale_stock_picking_blocking.pot
785982b
@oca-transbot @kirca
Update translation files
b37d02a 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@bjeficent @kirca
[MIG] sale_stock_picking_blocking: Migration to version 12.0
88cffd3
@oca-travis @kirca
Update translation files
66a1de6
@OCA-git-bot @kirca
[ADD] icon.png
b3b59b5
@Tonow-c2c @kirca
[12.0][FIX][sale_stock_picking_blocking] the _commercial_fields metho…
86c575e 
…d shoud return something
@OCA-git-bot @kirca
sale_stock_picking_blocking 12.0.1.0.1
99107ef
@OCA-git-bot @kirca
[UPD] README.rst
922cdab
@liweijie0812 @kirca
Translated using Weblate (Chinese (Simplified))
92c239d 
Currently translated at 100.0% (24 of 24 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_stock_picking_blocking
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_stock_picking_blocking/zh_CN/
@sudhir-erpharbor @kirca
[MIG] Migrated the module sale_stock_picking_blocking to v13.
29a9d34
@gurneyalex @kirca
Run pre-commit on sale_stock_picking_blocking
ea75c05
@jcoux @kirca
[MIG] sale_stock_picking_blocking: Migration to 14.0
e347ccc
@oca-travis @kirca
[UPD] Update sale_stock_picking_blocking.pot
e64a758
@OCA-git-bot @kirca
[UPD] README.rst
b3ae553
@kirca kirca force-pushed the 15.0-mig-sale_stock_picking_blocking branch 2 times, most recently from d020ced to d17e46c Compare May 17, 2022 12:48
@kirca kirca force-pushed the 15.0-mig-sale_stock_picking_blocking branch from d17e46c to 5d08b6a Compare May 17, 2022 12:51
@kirca kirca requested a review from rousseldenis May 17, 2022 12:59
leemannd
leemannd approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yvaucher
Copy link
Member

yvaucher commented Jun 9, 2022

@rousseldenis comments are solved this is ready to merge

@yvaucher
Copy link
Member

yvaucher commented Jun 9, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1888-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e726d82 into OCA:15.0 Jun 9, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 230af2f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd approved these changes

@yvaucher yvaucher yvaucher approved these changes

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

Assignees
No one assigned
Labels
merged 🎉 migration needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet