Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] sale_pre_order_amount: Migration to 15.0 #2011

Closed

Conversation

fshah-initos
Copy link

No description provided.

@fshah-initos fshah-initos force-pushed the 15.0-mig-sale_pre_order_amount branch 3 times, most recently from 0910eb8 to 69f18af Compare May 11, 2022 11:14
@fshah-initos fshah-initos force-pushed the 15.0-mig-sale_pre_order_amount branch from 69f18af to 4f72b74 Compare May 11, 2022 11:22
Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional tests.
Looks good to me.

@rousseldenis
Copy link
Sponsor Contributor

@fshah-initos Thanks for this.

But is this a new module ? If yes, you should rename to '[ADD] ...' instead of MIG

@fshah-initos fshah-initos changed the title [MIG] sale_pre_order_amount: Migration to 15.0 [ADD] sale_pre_order_amount: Migration to 15.0 May 20, 2022
@ikapasi-initos
Copy link

Hello, @rousseldenis it would be great if you can add reviews here.

@ikapasi-initos
Copy link

Hi, @ivantodorovich it would be great if you can add reviews here.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions github-actions bot closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants