Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_stock_cancel_restriction: migrate sale_stock_cancel_restriction #2043

Merged
merged 3 commits into from
Jun 30, 2022
Merged

[15.0][MIG] sale_stock_cancel_restriction: migrate sale_stock_cancel_restriction #2043

merged 3 commits into from
Jun 30, 2022

Conversation

cesar-tecnativa
Copy link
Contributor

@cesar-tecnativa cesar-tecnativa commented Jun 2, 2022 •
edited

@Tecnativa TT36542

@pedrobaeza
Copy link
Member

/ocabot migration sale_stock_cancel_restriction

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jun 6, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 6, 2022
Open
@pedrobaeza
Copy link
Member

@cesar-tecnativa Please avoid the merge commit.

@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch 4 times, most recently from e7f17aa to 7036fbe Compare June 7, 2022 20:22
@cesar-tecnativa
Copy link
Contributor Author

@cesar-tecnativa Please avoid the merge commit.
Done

@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from 7036fbe to 3408397 Compare June 7, 2022 20:26
pedrobaeza
pedrobaeza approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may complete the test coverage adding a test for a successful order cancellation (sometimes there are surprises in this way).

@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from 3408397 to 4093eb8 Compare June 8, 2022 14:59
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from 4093eb8 to ac23af8 Compare June 16, 2022 11:01
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from ac23af8 to 2260388 Compare June 16, 2022 16:03
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from 2260388 to f8fe0e0 Compare June 28, 2022 08:05
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from f8fe0e0 to b3b57d8 Compare June 28, 2022 15:18
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from b3b57d8 to ec763f1 Compare June 28, 2022 21:12
@cesar-tecnativa cesar-tecnativa force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from ec763f1 to 7d0e776 Compare June 30, 2022 12:22
@cesar-tecnativa
Copy link
Contributor Author

@victoralmau Could you please review it?

victoralmau
victoralmau approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK.

Could you squash administrative commits?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza force-pushed the 15.0-mig-sale_stock_cancel_restriction branch from 7d0e776 to 085d0da Compare June 30, 2022 17:45
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2043-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ad7fc2b into OCA:15.0 Jun 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 54ecfb7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cesar-tecnativa @pedrobaeza @OCA-git-bot @victoralmau @rousseldenis