[15.0] [MIG] product_form_sale_link #2138
Conversation
|
@ao-landoo would you be so kind and give me a review? |
|
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 has not been stricly followed. Migration commit is missing. |
|
Hey @CRogos, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
@ao-landoo thank you for your feedback. Shall I merge these two commits in the commit below (red) or above (green) arrow, or should it be left as is? The CLA message is now caused by the v13 migration commits. Is there some action needed? |
|
@ao-landoo I've now merged all OCA-git-bot commits with the commit above. Maybe you could have another look? |
|
@MiquelRForgeFlow I've added you improvement to the v15 port. maybe you could review? |
|
@simahawk could you also have a look at this? |
What's the problem? |
|
The result of pt.sale_lines_count is always 0 because
is always empty and I do not know how to mock this? |
|
@pedrobaeza could you merge this? |
|
Merging blindly based on the reviews: /ocabot migration product_form_sale_link |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza not continuing since 3 days |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza this isn't merging... anything I can do? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2138-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
| @@ -0,0 +1 @@ | |||
| ../../../../product_form_sale_link | |||
There was a problem hiding this comment.
The merge issue is because this should be a symlink, not a regular file?
To be investigated is why the bot does not report the error.
There was a problem hiding this comment.
The merge issue is because this should be a symlink, not a regular file? To be investigated is why the bot does not report the error.
As i can see here for example is the same:
https://github.com/OCA/sale-workflow/blob/16.0/setup/partner_sale_pivot/odoo/addons/partner_sale_pivot
There was a problem hiding this comment.
No, that one is really a symbolic link:
You need to delete the file and re-run pre-commit locally on a platform that supports symbolic links to generate it.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-product_form_sale_link/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-product_form_sale_link Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-product_form_sale_link/
The button 'action_view_sales' is replaced in sale_stock, so it cannot be referenced.
|
@pedrobaeza can you retry? Readded Joan and fixed the symbolic link. |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 5ad8e39. Thanks a lot for contributing to OCA. ❤️ |
Now contain also the improvements: PR-2120