-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0] [MIG] sale_order_price_recalculation #2139
[15.0] [MIG] sale_order_price_recalculation #2139
Conversation
…n demand sale order line prices ================================================== Recalculation of sale order lines prices on demand ================================================== This module adds a button on sale orders below pricelist that recalculates the prices of the order lines that contain a product in them. It is launched manually as a button to get the user decide if he/she wants to recalculate prices when pricelist is changed. Usage ===== Inside a sale order, you can click in any moment a button called "(Recalculate prices)", that is next to the pricelist selection, to launch a recalculation of all the prices of the lines, losing previous custom prices. Known issues / Roadmap ====================== * In a sale order with lot of lines, the recalculation may slow down, because sale general data (amount untaxed, amount taxed...) are recalculated for each line.
* add choice to recompute price only This commit add the capability to reset sale order line without renaming sale order lines * upgrade translation * Split functionnalities reset prices/reset desciptions * Move button under sale order lines
On certain set of installed modules, standard demo pricelist can be altered for giving something different than the list price, making these tests to fail. We avoid it creating our own pricelist with the fixed data that we want.
…st with discount_policy without_discount
This way, all tracking events can take place. Closes OCA#848
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_price_recalculation/de/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_price_recalculation/zh_CN/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_price_recalculation/pt_BR/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_price_recalculation/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_price_recalculation/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_price_recalculation/es/
With current inheritance, the buttons are only visible if you have the security group "Lock Confirmed Sales" in your user. As we need to be seen in all cases, we modify the inheritance. TT37124
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_price_recalculation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_price_recalculation/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inside a sale order, you can click on “Recalculate prices” to launch a recalculation of all the prices of the lines, losing previous custom prices.
I can't see that button
Button will be visible in draft and sent state only You can check it here http://oca-sale-workflow-15-0-pr2139-487d907a8d49.runboat.odoo-community.org/web#cids=1&menu_id=271&action=420&model=sale.order&view_type=form&id=27 Thanks |
But in previous versions, it was also available in sales order state. Why that change? |
It was like this in v13 Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
@JasminSForgeFlow when reviewing the PR in version 14, I thought I was able to do the recalculation after confirmation. But I was not. Sorry for the confusion. |
This PR work fine and test case passed too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR has the |
/ocabot migration sale_order_price_recalculation |
Hey, thanks for contributing! Proceeding to merge this for you. |
It looks like something changed on |
It looks like something changed on |
Congratulations, your PR was merged at 41900ea. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration
@ForgeFlow