[15.0] [MIG] sale_elaboration: Migration to v15 #2204

CarlosRoca13 · 2022-09-28T10:43:14Z

please @carlosdauden @sergio-teruel review this

victoralmau

Code review OK, some suggestions to reduce code.

victoralmau · 2022-09-28T15:04:54Z

sale_elaboration/models/product_elaboration.py

+        if not args:
+            args = []


Suggested change

if not args:

args = []

args = args if args else []

victoralmau · 2022-09-28T15:05:56Z

sale_elaboration/models/product_elaboration.py

+        if limit:
+            limit_rest = limit - len(recs)
+        else:  # pragma: no cover
+            # limit can be 0 or None representing infinite
+            limit_rest = limit


Suggested change

if limit:

limit_rest = limit - len(recs)

else: # pragma: no cover

# limit can be 0 or None representing infinite

limit_rest = limit

limit_rest = limit - len(recs) if limit else limit

victoralmau · 2022-09-28T15:13:04Z

sale_elaboration/views/sale_elaboration_views.xml

+        <field name="arch" type="xml">
+            <form string="Elaborations">
+                <sheet>
+                    <group>


Suggested change

<group>

<widget name="web_ribbon" title="Archived" bg_color="bg-danger" attrs="{'invisible': [('active', '=', True)]}"/>

<field name="active" invisible="1"/>

<group>

victoralmau · 2022-09-28T15:13:20Z

sale_elaboration/views/sale_elaboration_views.xml

+                    name="product_id"
+                    context="{'default_is_elaboration': True, 'default_type': 'service'}"
+                />
+                <field name="active" invisible="1" />


Suggested change

<field name="active" invisible="1" />

sale_elaboration/tests/test_sale_elaboration.py

rousseldenis · 2022-09-29T07:03:40Z

@victoralmau Shouldn't reviews be done on 14 migration PR and then pushed here ?

victoralmau · 2022-09-29T08:19:03Z

@victoralmau Shouldn't reviews be done on 14 migration PR and then pushed here ?

Ok, sorry, I didn't see the v14 migration PR.
@CarlosRoca13, can you apply these changes in v14?

victoralmau

Code review OK (It is probably better to merge v14 first, and then this one only with the necessary changes with respect to v15).

victoralmau · 2022-10-17T07:01:12Z

Can you update the commit history? The module is already merged in 14.0.

rousseldenis · 2022-10-21T06:36:33Z

/ocabot migration sale_elaboration

rousseldenis · 2022-10-21T06:38:12Z

@CarlosRoca13

sergio-teruel · 2022-10-21T10:21:49Z

@CarlosRoca13 You have already attended to @victoralmau comments, right?

…rence

… if not service

Currently translated at 36.7% (11 of 30 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_elaboration/de/

…r changes product

…sale order view to store the value in onchange method

…inventory reporting

…to allow users display elaboration notes on delivery slips

CarlosRoca13 · 2022-10-24T06:31:16Z

All changes done

victoralmau

Code review OK

OCA-git-bot · 2022-10-24T09:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2022-10-24T10:01:44Z

/ocabot merge nobump

OCA-git-bot · 2022-10-24T10:01:56Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-2204-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-10-24T10:16:04Z

Congratulations, your PR was merged at 7615955. Thanks a lot for contributing to OCA. ❤️

Signed-off-by pedrobaeza

CarlosRoca13 force-pushed the 15.0-MIG-sale_elaboration branch from f596b73 to f0ce0be Compare September 28, 2022 11:02

CarlosRoca13 mentioned this pull request Sep 28, 2022

[15.0] [MIG] product_supplierinfo_for_customer_elaboration: Migration to 15.0 #2206

Merged

victoralmau suggested changes Sep 28, 2022

View reviewed changes

CarlosRoca13 force-pushed the 15.0-MIG-sale_elaboration branch from f0ce0be to 613d730 Compare September 29, 2022 09:37

victoralmau reviewed Sep 29, 2022

View reviewed changes

CarlosRoca13 force-pushed the 15.0-MIG-sale_elaboration branch from 613d730 to 12ee1b8 Compare September 30, 2022 09:01

OCA-git-bot added this to the 15.0 milestone Oct 21, 2022

rousseldenis added needs review migration labels Oct 21, 2022

OCA-git-bot mentioned this pull request Oct 21, 2022

Migration to version 15.0 #1741

Open

sergio-teruel force-pushed the 15.0-MIG-sale_elaboration branch from e0615d7 to f551f82 Compare October 23, 2022 08:20

sergio-teruel and others added 13 commits October 24, 2022 08:24

[11.0][ADD] sale_elaboration: New module

e301f57

[11.0][ADD] sale_elaboration: Display elaboration code in picking

da2fcb0

[11.0][ADD] sale_elaboration: Display salesman in line views

8106e68

[11.0][FIX] sale_elaboration: Get first elaboration product

2e30831

[11.0][IMP] sale_elaboration: Add to invoice line the sale order refe…

c649e88

…rence

[IMP] sale_elaboration: Some improvements

9e57701

[11.0][ADD] sale_elaboration: Add is_elaboration in product template

5a28145

[IMP] sale_elaboration: Ensure test correctness + hide is_elaboration…

0d2a15a

… if not service

[11.0][FIX] sale_elaboration should't be auto installed

e79444a

Added translation using Weblate (German)

64755a4

Translated using Weblate (German)

f3fc8fd

Currently translated at 36.7% (11 of 30 strings) Translation: sale-workflow-11.0/sale-workflow-11.0-sale_elaboration Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-sale_elaboration/de/

[IMP] sale_elaboration: Reset "is_elaboration" in order line when use…

d2aeab4

…r changes product

[IMP] sale_elaboration: Set is_elaboration in product tests

37a6ef1

sergio-teruel and others added 13 commits October 24, 2022 08:24

[FIX] sale_elaboration: Apply force_save for field is_elaboration in …

cb19a19

…sale order view to store the value in onchange method

[MIG] sale_elaboration: Migration to v12.0

d84074c

[MIG] sale_elaboration: Migration to v12.0

8226a6d

[IMP] sale_elaboration: black, isort

49abfd4

[MIG] sale_elaboration: Migration to v13.0

a2f9d08

[IMP] sale_elaboration: Add menu entry to sale elaboration report at …

7734b56

…inventory reporting

[MIG] sale_elaboration: Migration to 14.0

0134df1

[UPD] Update sale_elaboration.pot

4bcc255

[UPD] README.rst

bbefbb5

[IMP] sale_elaboration: black, isort, prettier

5a0a253

[MIG] sale_elaboration: Migration to v15

44f42bf

[IMP] sale_elaboration: Improve elaboration tree view

95a5d93

[FIX] sale_elaboration: Fix delivery slip report. Add config setting …

43aaf31

…to allow users display elaboration notes on delivery slips

CarlosRoca13 force-pushed the 15.0-MIG-sale_elaboration branch from f551f82 to 43aaf31 Compare October 24, 2022 06:30

victoralmau approved these changes Oct 24, 2022

View reviewed changes

carlosdauden approved these changes Oct 24, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 24, 2022

OCA-git-bot added the bot is merging ⏳ label Oct 24, 2022

OCA-git-bot merged commit d0d7663 into OCA:15.0 Oct 24, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 24, 2022

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 7, 2023

Merge PR OCA#2204 into 15.0

ff84b6e

Signed-off-by pedrobaeza

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0] [MIG] sale_elaboration: Migration to v15 #2204

[15.0] [MIG] sale_elaboration: Migration to v15 #2204

CarlosRoca13 commented Sep 28, 2022

victoralmau left a comment

victoralmau Sep 28, 2022

victoralmau Sep 28, 2022

victoralmau Sep 28, 2022

victoralmau Sep 28, 2022

rousseldenis commented Sep 29, 2022

victoralmau commented Sep 29, 2022

victoralmau left a comment

victoralmau commented Oct 17, 2022

rousseldenis commented Oct 21, 2022

rousseldenis commented Oct 21, 2022

sergio-teruel commented Oct 21, 2022

CarlosRoca13 commented Oct 24, 2022

victoralmau left a comment

OCA-git-bot commented Oct 24, 2022

pedrobaeza commented Oct 24, 2022

OCA-git-bot commented Oct 24, 2022

OCA-git-bot commented Oct 24, 2022

-                    <group>
+                    <widget name="web_ribbon" title="Archived" bg_color="bg-danger" attrs="{'invisible': [('active', '=', True)]}"/>
+                    <field name="active" invisible="1"/>
+                    <group>

[15.0] [MIG] sale_elaboration: Migration to v15 #2204

[15.0] [MIG] sale_elaboration: Migration to v15 #2204

Conversation

CarlosRoca13 commented Sep 28, 2022

victoralmau left a comment

Choose a reason for hiding this comment

victoralmau Sep 28, 2022

Choose a reason for hiding this comment

victoralmau Sep 28, 2022

Choose a reason for hiding this comment

victoralmau Sep 28, 2022

Choose a reason for hiding this comment

victoralmau Sep 28, 2022

Choose a reason for hiding this comment

rousseldenis commented Sep 29, 2022

victoralmau commented Sep 29, 2022

victoralmau left a comment

Choose a reason for hiding this comment

victoralmau commented Oct 17, 2022

rousseldenis commented Oct 21, 2022

rousseldenis commented Oct 21, 2022

sergio-teruel commented Oct 21, 2022

CarlosRoca13 commented Oct 24, 2022

victoralmau left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 24, 2022

pedrobaeza commented Oct 24, 2022

OCA-git-bot commented Oct 24, 2022

OCA-git-bot commented Oct 24, 2022