[FIX][14.0] pricelist_cache: change root pricelist job execution #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmequignon
approved these changes
Mar 21, 2023
| pricelist_id, | ||
| ] | ||
| ) | ||
| # Spawn a job every 3 oter pricelists (reduce the number of jobs created) |
| # Spawn a job every 3 pricelists (reduce the number of jobs created) | ||
| # pricelists = self.env["product.pricelist"].search([]) | ||
| pricelists_root = self.env["product.pricelist"]._get_root_pricelist_ids() | ||
| pricelist_ids = [plid for plid in pricelist_ids if plid not in pricelists_root] |
There was a problem hiding this comment.
Suggested change
| pricelist_ids = [plid for plid in pricelist_ids if plid not in pricelists_root] | |
| pricelist_ids = self.env["product.pricelist"].search([("id", "not in", pricelist_root)]) |
and remove line 194, maybe?
TDu
force-pushed
the
pcache-job-fix
branch
3 times, most recently
from
4c03632
to
27ca4e0
Compare
Root pricelist take a long time to compute. So execute computation one by one.
mmequignon
approved these changes
May 3, 2023
dreispt
approved these changes
May 18, 2024
|
/ocabot merge patch |
|
@dreispt The merge process could not start, because command `git merge --no-ff -m 'Merge PR #2424 into 14.0 Signed-off-by dreispt' tmp-pr-2424` failed with output: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root pricelist take a long time to compute.
So execute computation one by one.