[FIX] do not generate payment if amount=0 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damdam-s
changed the title
|
👍 |
|
It's a WIP? Anyway, it seems 👍 |
gurneyalex
changed the title
|
👍 in principle, thanks. Still I am unsure: should we consider a near-zero amount because of float or rounding problems? |
|
closed by mistake, I reopen |
|
I agree with @lepistone : I think we should consider using |
|
👍 |
|
Actually, 👎 : I didn't notice that the condition was |
damdam-s
force-pushed
the
8.0-sale_payment_method-amount_zero
branch
from
852a6d3
to
26796f0
Compare
|
@mdietrichc2c ouch ... :( sorry. fix done |
| @@ -103,8 +104,10 @@ def automatic_payment(self, amount=None): | |||
| amounts = [(date, amount)] | |||
|
|
|||
| # reversed is cosmetic, compute returns terms in the 'wrong' order | |||
| precision = self.env['decimal.precision'].precision_get('Account') | |||
There was a problem hiding this comment.
please move this up 1 line, otherwise the comment does not make sense.
|
A minor remark, otherwise 👍 thanks! |
|
@lepistone done |
|
👍 |
1 similar comment
|
👍 |
BT-dherreros
pushed a commit
to BT-dherreros/sale-workflow
that referenced
this pull request
Apr 29, 2019
Syncing from upstream OCA/sale-workflow (12.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.