7.0 set date_validity to proper value on copy() #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert class names to camelcase
| ''' | ||
| By default, date_order is set to today on copy() | ||
| cf addons/sale/sale.py. So we set date_validity to | ||
| it's default value on copy() |
There was a problem hiding this comment.
it's -> its or this but not it's
| @@ -59,6 +59,19 @@ def _default_date_validity(self, cr, uid, context=None): | |||
| 'date_validity': _default_date_validity, | |||
| } | |||
|
|
|||
| def copy(self, cr, uid, id, default=None, context=None): | |||
| ''' | |||
There was a problem hiding this comment.
Use double-quotes for docstring
|
Minor remark, but 👍 |
|
Could someone with the super-powers merge this please ? |
|
@alexis-via, we need 2 or more Up vote to merge. You could ask for label change to "needs review"(as OCA members follow through needs review label to check the PR status/review) code reviewed: 👍 |
|
Code review 👍 |
BT-dherreros
pushed a commit
to BT-dherreros/sale-workflow
that referenced
this pull request
Apr 29, 2019
Syncing from upstream OCA/sale-workflow (12.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.