v9 Migration of sale_cancel_reason #261

JayVora-SerpentCS · 2016-01-29T15:03:36Z

No description provided.

pedrobaeza · 2016-01-29T15:07:26Z

Can you please squash the commits a bit?

pedrobaeza · 2016-01-29T15:07:56Z

sale_cancel_reason/__openerp__.py

+    'complexity': 'normal',
+    'images': [],
+    'website': "http://www.camptocamp.com",
+    'description': """
 Sale Cancel Reason


Put description in a README.rst according conventions (https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst)

tafaRU · 2016-01-29T15:30:18Z

Please also have a look at https://travis-ci.org/OCA/sale-workflow/builds/105690296 errors.
By the way, thank you for your contrib!

oca-clabot · 2016-02-03T11:13:55Z

Hey @JayVora-SerpentCS, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@akashpatel3193 (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

JayVora-SerpentCS · 2016-07-29T07:31:14Z

Please check.

pedrobaeza · 2016-07-29T08:35:14Z

You must import the commit history from the migration moment following this guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 and squash commits to only relevant ones.

JayVora-SerpentCS · 2016-07-29T15:08:37Z

Sure, will do! Sounds pretty good set of notes (y)

atchuthan · 2016-08-04T06:15:10Z

sale_cancel_reason/README.rst

+
+* To configure this module, you need to:
+
+* You can cofigure cancel reason from Sale -> Configuration -> Sale Order Cancel Reason.


n/cofigure/configure

atchuthan · 2016-08-04T07:03:22Z

code reviewed 👍
few minor changes and rebase commits from 8.0 as per @pedrobaeza request

pedrobaeza · 2016-08-04T07:09:07Z

sale_cancel_reason/wizard/cancel_reason_view.xml

-            </form>
-            </field>
-        </record>
+<data noupdate="0">


<odoo>, not <data>

@JayVora-SerpentCS would you be able to fix this misunderstanding? Like @pedrobaeza says, the data tag is redundant in 9.0, so please replace with the odoo tag.

StefanRijnhart · 2016-10-12T19:49:38Z

sale_cancel_reason/models/sale.py

@@ -28,8 +29,7 @@ class SaleOrder(models.Model):
    cancel_reason_id = fields.Many2one(
        'sale.order.cancel.reason',
        string="Reason for cancellation",
-        readonly=True,
-        ondelete="restrict")


By removing the ondelete behaviour the default 'set null' will apply. Reasons that were applied to sale orders can be removed, leaving the value empty. Is that what you want?

More common is not to allow this, but to allow reasons to be set to inactive so that they cannot be assigned anymore.

Added an active field to manage this.
Thanks.

StefanRijnhart · 2016-10-12T19:55:18Z

@JayVora-SerpentCS should be very easy to have this in a mergeable state, if you have a couple of minute. Nice description page!

pedrobaeza · 2016-10-28T00:56:22Z

Any update of this?

JayVora-SerpentCS · 2016-11-11T12:36:40Z

Will find some tome and push

pedrobaeza · 2016-12-24T18:15:55Z

Are you going to finally work on this?

JayVora-SerpentCS · 2016-12-26T14:14:42Z

Sorry, lost it. doing in this week for sure!

JayVora-SerpentCS · 2016-12-31T10:25:40Z

You may proceed please.

JayVora-SerpentCS · 2017-01-10T14:55:45Z

@pedrobaeza I am unable to see what fails on runbot. Can you help please?

StefanRijnhart · 2017-01-10T18:19:46Z

@JayVora-SerpentCS I think it's the warnings raised by sale_rental. Don't worry about it.

JayVora-SerpentCS · 2017-01-17T06:28:35Z

Kindly check.

pedrobaeza · 2017-01-17T07:51:27Z

Runbots errors are in fact warnings from other module (sale_rental):

2017-01-11 13:49:54,128 216 WARNING openerp_test openerp.models: method product.product._check_rental: @constrains parameter 'must_have_dates' is not writeable
2017-01-11 13:49:54,128 216 WARNING openerp_test openerp.models: method product.product._check_rental: @constrains parameter 'type' is not writeable
2017-01-11 13:49:54,128 216 WARNING openerp_test openerp.models: method product.product._check_rental: @constrains parameter 'uom_id' is not writeable

pedrobaeza · 2017-03-18T16:43:35Z

sale_cancel_reason/README.rst

+   :target: https://www.gnu.org/licenses/agpl.html
+   :alt: License: AGPL-3
+
+Sale Cancel Reason


Put the same lines above

pedrobaeza

Some tests would be welcome.

pedrobaeza · 2017-03-18T16:43:46Z

sale_cancel_reason/README.rst

+This module introduce the following features:
+
+* This module allows cancel sale order and reason must be given.
+


Don't put this extra line

pedrobaeza · 2017-03-18T16:44:10Z

sale_cancel_reason/README.rst

+=============
+
+* To configure this module, you need to:
+


Remove extra line and replace * by #. for numbered list.

pedrobaeza · 2017-03-18T16:44:16Z

sale_cancel_reason/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/167/8.0


pedrobaeza · 2017-03-18T16:44:24Z

sale_cancel_reason/README.rst

+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/167/8.0
+
+For further information, please visit:


Remove this paragraph

pedrobaeza · 2017-03-18T16:44:43Z

sale_cancel_reason/README.rst

+Maintainer
+----------
+
+.. image:: http://odoo-community.org/logo.png


s/http/https in both places

pedrobaeza · 2017-03-18T16:45:00Z

sale_cancel_reason/__openerp__.py

+    'name': 'Sale Cancel Reason',
+    'version': '9.0.1.0.0',
+    'author': 'Camptocamp, Odoo Community Association (OCA), '
+            'Serpent Consulting Services Pvt. Ltd.',


Fix indentation

pedrobaeza · 2017-03-18T16:45:16Z

sale_cancel_reason/data/sale_order_cancel_reason.xml

+    <record id="cancel_reason_other_provider" model="sale.order.cancel.reason">
+        <field name="name">Other Service Provider selected</field>
+    </record>
+</odoo>


Line at the end

This is done, I wonder why the diff shows it open.

pedrobaeza · 2017-03-18T16:46:05Z

sale_cancel_reason/models/sale.py

@@ -29,11 +30,15 @@ class SaleOrder(models.Model):
        'sale.order.cancel.reason',
        string="Reason for cancellation",
        readonly=True,
-        ondelete="restrict")
+        ondelete='restrict')


Next time, don't make these stylistic changes that increases diffs.

pedrobaeza · 2017-03-18T16:47:20Z

sale_cancel_reason/wizard/__init__.py

@@ -3,6 +3,7 @@
 #
 #    Author: Guewen Baconnier
 #    Copyright 2013 Camptocamp SA
+#    Copyright 2016 Serpent Consulting Services Pvt. Ltd.


Don't add your copyright on non touched files (and more if they are __init__.py files.

JayVora-SerpentCS · 2017-03-30T14:38:04Z

Will do the changes asap.

LoisRForgeFlow

Thanks for the work! Some comments in line.

LoisRForgeFlow · 2017-04-25T07:55:26Z

sale_cancel_reason/README.rst

+Installation
+============
+
+ No external library is used.


I think you can remove unneeded sections. Also this is displayed as a quotation due to the initial space in the line.

LoisRForgeFlow · 2017-04-25T07:56:56Z

sale_cancel_reason/README.rst

+=============
+
+* To configure this module, you need to:
+*#. You can configure cancel reason from Sale -> Configuration -> Sale Order Cancel Reason.


remove initial asterisks, this is not going to be displayed well.

LoisRForgeFlow · 2017-04-25T07:59:11Z

sale_cancel_reason/__openerp__.py

+              'Serpent Consulting Services Pvt. Ltd.',
+    'category': 'Sale',
+    'license': 'AGPL-3',
+    'complexity': 'normal',


This can be removed I think

LoisRForgeFlow · 2017-04-25T08:00:08Z

sale_cancel_reason/__openerp__.py

-          ],
- 'installable': False,
- }
+    'test': ['test/sale_order_cancel.yml'],


Can you move the tests to python?

LoisRForgeFlow · 2017-04-25T08:01:53Z

sale_cancel_reason/data/sale_order_cancel_reason.xml

@@ -1,14 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
-<openerp>
-    <data noupdate="1">


Why did you remove the original noupdate="1"?

Accidental due to removal of , its back now.

LoisRForgeFlow · 2017-04-25T08:03:03Z

sale_cancel_reason/static/description/index.html

+            </div>
+        </div>
+    </div>
+</section>


Final extra line

LoisRForgeFlow · 2017-04-25T08:07:23Z

sale_cancel_reason/static/description/index.html

+            <h3 class="oe_slogan">It is chosen from a configured list</h3>
+            <div class="oe_span6">
+               <p class="oe_mt32">
+                    1) Sale Order Configuretion.


Configuretion - > Configuration

serpentcs-dev1 · 2017-05-10T06:14:08Z

sale_cancel_reason/__openerp__.py

- }
+    'installable': True,
+    'application': True,
+    'auto_install': False,


@JayVora-SerpentCS not necessary, and can you also please add OCA icon in static/description

Its there -https://github.com/JayVora-SerpentCS/sale-workflow/blob/9.0/sale_cancel_reason/static/description/icon.png

[IMP] Improved the code / content as per GIT review and OCA standards.

[IMP] Fix the travis.

sudhir-serpentcs · 2017-09-04T09:57:46Z

@StefanRijnhart @lreficent @pedrobaeza Please review and provide feedback if any.

LoisRForgeFlow

Tested on runbot 👍

serpentcs-dev1

Code review LGTM 👍

* [10.0] re-introduce state field on product * [ADD] add setup for product state

pedrobaeza mentioned this pull request Jan 29, 2016

Migration to version 9.0 #223

Closed

50 tasks

pedrobaeza reviewed Jan 29, 2016
View reviewed changes

JayVora-SerpentCS force-pushed the 9.0 branch from e079556 to 145efa8 Compare February 18, 2016 12:15

StefanRijnhart added the needs fixing label Mar 31, 2016

StefanRijnhart added this to the 9.0 milestone Mar 31, 2016

atchuthan reviewed Aug 4, 2016
View reviewed changes

pedrobaeza reviewed Aug 4, 2016
View reviewed changes

StefanRijnhart reviewed Oct 12, 2016

View reviewed changes

JayVora-SerpentCS force-pushed the 9.0 branch from fceb406 to 59b903b Compare December 31, 2016 10:16

pedrobaeza reviewed Mar 18, 2017

View reviewed changes

pedrobaeza requested changes Mar 18, 2017

View reviewed changes

JayVora-SerpentCS closed this Apr 24, 2017

JayVora-SerpentCS force-pushed the 9.0 branch from 0d0d547 to cc4e881 Compare April 24, 2017 12:49

JayVora-SerpentCS reopened this Apr 24, 2017

JayVora-SerpentCS force-pushed the 9.0 branch from 17dca97 to 584f52d Compare April 24, 2017 12:56

LoisRForgeFlow reviewed Apr 25, 2017

View reviewed changes

JayVora-SerpentCS force-pushed the 9.0 branch from 584f52d to 513d6e8 Compare April 25, 2017 09:43

[MIG] Migration to v9

b316dd5

JayVora-SerpentCS force-pushed the 9.0 branch from 513d6e8 to b316dd5 Compare April 25, 2017 09:49

Added tests

0de9eba

serpentcs-dev1 reviewed May 10, 2017

View reviewed changes

[IMP] Improved the code / content as per GIT review and OCA standards.

b4925f8

sudhir-serpentcs mentioned this pull request Sep 1, 2017

[IMP] Improved the code / content as per GIT review and OCA standards. JayVora-SerpentCS/sale-workflow#3

Merged

JayVora-SerpentCS and others added 4 commits September 1, 2017 18:56

Merge pull request #3 from sudhir-serpentcs/9.0-MIG-sale_cancel_reason

cec137d

[IMP] Improved the code / content as per GIT review and OCA standards.

[IMP] Fix the travis.

a76b40f

Update __openerp__.py

38a4343

Merge pull request #4 from sudhir-serpentcs/9.0

9bdc31c

[IMP] Fix the travis.

LoisRForgeFlow approved these changes Sep 5, 2017

View reviewed changes

StefanRijnhart approved these changes Nov 13, 2017

View reviewed changes

serpentcs-dev1 approved these changes Nov 13, 2017

View reviewed changes

pedrobaeza approved these changes Nov 22, 2017

View reviewed changes

pedrobaeza merged commit 8b5c853 into OCA:9.0 Nov 22, 2017

norlinhenrik pushed a commit to loymcom/sale-workflow that referenced this pull request Sep 20, 2023

re-introduce state field on product (OCA#261)

e96a950

* [10.0] re-introduce state field on product * [ADD] add setup for product state


		* To configure this module, you need to:

		* You can cofigure cancel reason from Sale -> Configuration -> Sale Order Cancel Reason.

		This module introduce the following features:

		* This module allows cancel sale order and reason must be given.

v9 Migration of sale_cancel_reason #261

v9 Migration of sale_cancel_reason #261

Conversation

JayVora-SerpentCS commented Jan 29, 2016

pedrobaeza commented Jan 29, 2016

Choose a reason for hiding this comment

tafaRU commented Jan 29, 2016

oca-clabot commented Feb 3, 2016

JayVora-SerpentCS commented Jul 29, 2016

pedrobaeza commented Jul 29, 2016

JayVora-SerpentCS commented Jul 29, 2016

Choose a reason for hiding this comment

atchuthan commented Aug 4, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StefanRijnhart commented Oct 12, 2016

pedrobaeza commented Oct 28, 2016

JayVora-SerpentCS commented Nov 11, 2016 • edited

pedrobaeza commented Dec 24, 2016

JayVora-SerpentCS commented Dec 26, 2016

JayVora-SerpentCS commented Dec 31, 2016

JayVora-SerpentCS commented Jan 10, 2017

StefanRijnhart commented Jan 10, 2017

JayVora-SerpentCS commented Jan 17, 2017

pedrobaeza commented Jan 17, 2017

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JayVora-SerpentCS commented Mar 30, 2017

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LoisRForgeFlow Apr 25, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serpentcs-dev1 May 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sudhir-serpentcs commented Sep 4, 2017

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

serpentcs-dev1 left a comment

Choose a reason for hiding this comment

JayVora-SerpentCS commented Nov 11, 2016 •

edited

LoisRForgeFlow Apr 25, 2017 •

edited

serpentcs-dev1 May 10, 2017 •

edited