[FIX] When pickings are recreated from shipping excepting, order "View Delivery Orders" button disappears #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenvac
commented
Feb 23, 2016
kenvac
commented
- Fix [8.0][sale_procurement_group_by_line] Recreate pickings doesn't show View Delivery Orders button #264
- Fix : Can't create delivery from shipping exception
| @@ -49,7 +49,15 @@ def action_ship_create(self, cr, uid, ids, context=None): | |||
| groups = {} | |||
|
|
|||
| for line in order.order_line: | |||
| group_id = groups.get(line._get_procurement_group_key()) | |||
| if order.state == 'shipping_except': | |||
| try: | |||
There was a problem hiding this comment.
Why a try? Use
groups.get(line...
There was a problem hiding this comment.
You are right @pedrobaeza . This can be removed. I'll make the change and also need to check why CI is failing.
kenvac
force-pushed
the
8.0-sale_procurement_group_by_line-fix
branch
from
6d1cf38
to
13aec39
Compare
|
@pedrobaeza I've made those changes. Thanks for pointing it out. |
|
👍 |
kenvac
force-pushed
the
8.0-sale_procurement_group_by_line-fix
branch
from
13aec39
to
3b626db
Compare
| @@ -70,6 +76,7 @@ def action_ship_create(self, cr, uid, ids, context=None): | |||
| # trigger another move | |||
| proc_ids += [x.id for x in line.procurement_ids | |||
| if x.state in ('exception', 'cancel')] | |||
| procurement_obj.reset_to_confirmed(cr, uid, proc_ids, context=context) | |||
There was a problem hiding this comment.
This line is too long:
sale_procurement_group_by_line/model/sale.py:79:80: E501 line too long (90 > 79 characters)
3e2942c
to
ff150f6
Compare
|
@pedrobaeza pep8 convention enforced in code |
| @@ -49,7 +49,13 @@ def action_ship_create(self, cr, uid, ids, context=None): | |||
| groups = {} | |||
|
|
|||
| for line in order.order_line: | |||
| if order.state == 'shipping_except': | |||
| group_id = getattr(line.procurement_group_id, 'id') | |||
There was a problem hiding this comment.
This looks like a void statement to me. group_id is not used in the loop, and overwritten right after.
|
@kenvac, can you check Stefan's comment? |
* Fix OCA#264 * Fix : Can't create delivery from shipping exception
mistotebe
force-pushed
the
8.0-sale_procurement_group_by_line-fix
branch
from
ff150f6
to
110a5c0
Compare
|
I've made the change suggested above. |
|
Thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.