[FIX] fix perf issue with sale_order_lot_selection #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ('id', 'child_of', location.id), | ||
| ]) | ||
| # Search all lot existing lot for the product and location selected | ||
| self._cr.execute("""SELECT lot_id |
There was a problem hiding this comment.
You can use quants for searching, but without SQL. The performance will be for sure still good. You can use read_group function if you want to increase it. This way, you don't overpass multi-company rules, and so on.
There was a problem hiding this comment.
good idea, let's fix it
sebastienbeau
force-pushed
the
8.0-fix-perf-issue-with-sale-order-lot-selection
branch
2 times, most recently
from
ef29da6
to
b626fed
Compare
sebastienbeau
force-pushed
the
8.0-fix-perf-issue-with-sale-order-lot-selection
branch
from
b626fed
to
119a5ba
Compare
|
@pedrobaeza everything is green and use read_group ;) |
|
Thanks 👍 |
|
👍 |
|
👍 |
pedrobaeza
added a commit
that referenced
this pull request
Mar 9, 2016
…der-lot-selection [FIX] fix perf issue with sale_order_lot_selection
sebastienbeau
deleted the
8.0-fix-perf-issue-with-sale-order-lot-selection
branch
|
Thanks 😄 |
|
Really Thank You @sebastienbeau 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first thank to Agilebg for this module
I have some perf issue with sale_order_selection_lot. Indeed my customer have more than 4000 lot for a product and when he try to select it in a sale order the function spend 3 min to compute the lot available.
With this change it spend less than 0,023s
What do you think?
@hurrinico @eLBati
Thanks for you're feedback