[ADD] add module to deliver when creating invoice #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laetitia-gangloff
changed the title
laetitia-gangloff
force-pushed
the
8.0-sale_invoice_auto_deliver-lga
branch
2 times, most recently
from
abed1af
to
e8f2d2a
Compare
|
👍 Tests and code |
Cedric-Pigeon
force-pushed
the
8.0-sale_invoice_auto_deliver-lga
branch
from
fc1cdef
to
80b19d7
Compare
|
@laetitia-gangloff @Cedric-Pigeon this PR is failing runbot and travis, please could you review and fix errors? We are in the OCA Code Sprint and are reviewing for get merge, thanks! |
|
@rafaelbn I am in the room also ;-) I will have a look this morning. |
rafaelbn
requested changes
Jun 12, 2017
There was a problem hiding this comment.
Please add test, as in #280 (comment) Coverage decreased (-27.0%) to 46.899% . Thanks!
|
Closing this as no activity. @laetitia-gangloff Please feel free to reopen it if you still need it. Take care of your PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sale advance payment, add option to deliver at the same time than invoice.
If picking are not validable, an error is raised.