[MIG][9.0] sale automatic workflow #291

SodexisTeam · 2016-04-22T07:05:23Z

https://odoo-community.org/groups/contributors-15/contributors-39175

…rder workflow

… task, indeed if we did it in the workflow we can not anymore unreconcile an invoice because it will be re-reconcile directly

…eed this feature was still not reimplemented

…commit

… to False params raise_error as it's a boolean

… should be process individualy

…tracted

…orting exchange write off

…ment by sale_quick_payment

…f the voucher

…t need anymore to open a new one

…dency

…d actually

…ve to use this onchange

…der_policy, remove the 'postpaid' removed in openerp

… method

coveralls · 2016-05-12T07:56:25Z

Coverage increased (+4.4%) to 80.074% when pulling c44d8ab on sodexis:9.0-sale_automatic_workflow into d368776 on OCA:9.0.

coveralls · 2016-05-12T08:33:34Z

Coverage increased (+4.4%) to 80.074% when pulling 061300d on sodexis:9.0-sale_automatic_workflow into d368776 on OCA:9.0.

atchuthan · 2016-05-12T10:32:57Z

@guewen we can change the label to "Needs review"

guewen · 2016-05-12T11:30:50Z

@guewen we can change the label to "Needs review"

yeah!

guewen · 2016-05-12T11:47:26Z

sale_automatic_workflow/views/sale_view.xml

+              <field name="workflow_process_id"/>
+            </group>
+          </page>
+		</xpath>


Tabs spotted

guewen · 2016-05-12T11:49:48Z

There is a small issue with the Configuration menu (same issue in sale_exception btw):

guewen · 2016-05-12T11:55:38Z

I really like the feature to customize the filters, well done!

Thanks :)

2 small things to fix, but 👍

coveralls · 2016-05-12T12:26:36Z

Coverage increased (+4.4%) to 80.074% when pulling a41b0db on sodexis:9.0-sale_automatic_workflow into d368776 on OCA:9.0.

coveralls · 2016-05-30T07:04:57Z

Coverage increased (+4.4%) to 80.074% when pulling e08a7ac on sodexis:9.0-sale_automatic_workflow into d368776 on OCA:9.0.

The addon does not install if the table sale_workflow_process contains records without filters, Odoo tries to get the xmlids of the default values before the filters are created.

guewen · 2016-06-13T14:38:40Z

@atchuthan here's a fix for a corner case during the installation (existing records in sale.workflow.process, default are called before the filters are created): sodexis#1

Fix default filters

coveralls · 2016-06-14T05:37:04Z

Coverage increased (+4.4%) to 80.072% when pulling ca9257c on sodexis:9.0-sale_automatic_workflow into d368776 on OCA:9.0.

atchuthan · 2016-06-14T05:40:06Z

@guewen thanks for the fix.

gurneyalex · 2016-06-22T13:42:42Z

👍

rafaelbn · 2016-06-22T14:14:55Z

sale_automatic_workflow/README.rst

+  * Validate the invoice
+  * Confirm the picking
+
+This module is used by Magentoerpconnect and Prestashoperpconnect.


@pedrobaeza @sergio-teruel take a look for Prestashoperpconnect

rafaelbn · 2016-06-22T14:19:41Z

Nice work thanks. 👍

rousseldenis · 2017-05-04T13:35:38Z

@atchuthan I try to review the v10 migration, but I need some explanation about the filter (the char field).

Why having removed the char_domain widget ? So, as the char field is not used in code (filter_id is used), why isn't it in readonly?

atchuthan · 2017-05-08T06:46:18Z

@rousseldenis sorry for the delay

first, we had a thought of using the char field directly but later due to time constraint, we worked directly with the filter.
Our idea was to use this char field where the users could setup their custom filter domain instead of making modifications to the filter domain directly.

Let us know if you need any support from our side. Thanks and let us know if you have started PR for v10 migration.

rousseldenis · 2017-05-08T07:42:59Z

@atchuthan The migration to v10 has been started by @lasley

I want to port this discussion to #391

sebastienbeau and others added 30 commits April 22, 2012 14:49

[ADD] add sale_automatic_workflow, a module to automatized the sale o…

db81f0a

…rder workflow

[IMP] sale_automatic_workflow : add default value for workflow method

6d7d798

[FIX] sale_automatic_workflow : fix invoice creation from picking

ed2897c

[IMP] sale_automatic_workflow: redesign of sale order view

4e03eca

[FIX] sale_automatic_workflow : add missing security rule

330890d

[FIX] sale_automatic_workflow : reconciled should be done by the cron…

292253c

… task, indeed if we did it in the workflow we can not anymore unreconcile an invoice because it will be re-reconcile directly

[FIX] sale_automatic_wokflow : fix the option force invoice date, ind…

fe905d5

…eed this feature was still not reimplemented

[REF] refactor/clean code due to orm change in 6.1

f1cffff

[MERGE] sale_automatic_workflow : merge fix

fe029c2

[IMP] sale_automatic_workflow : use context manager for intermediary …

99eb228

…commit

[IMP] sale_automatic_workflow : add doc string for commit_now and set…

fefbdf8

… to False params raise_error as it's a boolean

Ir.cron protected by a noupdate flag.

f6d8c47

[IMP] sale_automatic_workflow : invoice validation and reconciliation…

7bae3fd

… should be process individualy

[REF] import the commit_now from framework_helpers as it have been ex…

ad5abee

…tracted

[FIX] Open a new cursor before commiting it, thanks to Guewen ideas

667519b

[IMP] set correctly the version number 6.1.X

0e69e25

[IMP] sale_automatic_workflow: improve invoice reconciliation by supp…

80f032a

…orting exchange write off

[MIGR] sale_automatic_workflow: move code in the correct file

15a03ed

[MIGR] sale_automatic_workflow: migration module to V7

dca55ab

[FIX] sale_automatic_workflow: replace dependencies on sale_quick_pay…

a782f2d

…ment by sale_quick_payment

[IMP] sale_automatic_worflow: reconcile with the move lines instead o…

3f4a9c7

…f the voucher

[IMP] sale_automatic_workflow: review

0f7fe0a

[FIX] since openerp 7, the crons callee have their own cr, so we don'…

fd13fb9

…t need anymore to open a new one

[IMP] review the workflow job, get rid of the framework helpers depen…

ca9857c

…dency

[FIX] remove the field 'validate_manufactoring_order', not implemente…

f719a6e

…d actually

[IMP] use an onchange to apply the default values (connectors will ha…

8fc6248

…ve to use this onchange

[FIX] rename onchange_workflow_process to onchange_workflow_process_id

2ba6384

[IMP] sale_automatic_workflow: use the same words than openerp for or…

8b580fc

…der_policy, remove the 'postpaid' removed in openerp

[IMP] sale_automatic_workflow: display the workflow below the payment…

aa7a560

… method

[IMP] sale_automatic_workflow: the onchange apply the workflow

bfde4e9

[FIX] separated payment portion

061300d

SodexisTeam changed the title ~~[WIP][9.0] sale automatic workflow~~ [MIG][9.0] sale automatic workflow May 12, 2016

guewen added needs review and removed work in progress labels May 12, 2016

guewen reviewed May 12, 2016
View reviewed changes

sale_automatic_workflow/views/sale_view.xml

<field name="workflow_process_id"/>

</group>

</page>

</xpath>

Copy link

Member

guewen May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs spotted

[FIX] corrections

a41b0db

guewen mentioned this pull request May 12, 2016

[FIX] configuration menu correction for sale_exception #300

Merged

[MVD] moved payment filter to sale_automatic_workflow_payment_mode

e08a7ac

Fix default filters

7a2414c

The addon does not install if the table sale_workflow_process contains records without filters, Odoo tries to get the xmlids of the default values before the filters are created.

Merge pull request #1 from guewen/sodexis-9.0-sale_automatic_workflow

ca9257c

Fix default filters

rafaelbn added this to the 9.0 milestone Jun 22, 2016

rafaelbn reviewed Jun 22, 2016
View reviewed changes

gurneyalex merged commit 1c12fd3 into OCA:9.0 Jun 23, 2016

atchuthan deleted the 9.0-sale_automatic_workflow branch June 23, 2016 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][9.0] sale automatic workflow #291

[MIG][9.0] sale automatic workflow #291

SodexisTeam commented Apr 22, 2016

coveralls commented May 12, 2016 •

edited

Loading

coveralls commented May 12, 2016 •

edited

Loading

atchuthan commented May 12, 2016

guewen commented May 12, 2016

guewen May 12, 2016

guewen commented May 12, 2016 •

edited

Loading

guewen commented May 12, 2016

coveralls commented May 12, 2016 •

edited

Loading

coveralls commented May 30, 2016 •

edited

Loading

guewen commented Jun 13, 2016

coveralls commented Jun 14, 2016 •

edited

Loading

atchuthan commented Jun 14, 2016

gurneyalex commented Jun 22, 2016

rafaelbn Jun 22, 2016

rafaelbn commented Jun 22, 2016

rousseldenis commented May 4, 2017

atchuthan commented May 8, 2017

rousseldenis commented May 8, 2017

[MIG][9.0] sale automatic workflow #291

[MIG][9.0] sale automatic workflow #291

Conversation

SodexisTeam commented Apr 22, 2016

coveralls commented May 12, 2016 • edited Loading

coveralls commented May 12, 2016 • edited Loading

atchuthan commented May 12, 2016

guewen commented May 12, 2016

guewen May 12, 2016

Choose a reason for hiding this comment

guewen commented May 12, 2016 • edited Loading

guewen commented May 12, 2016

coveralls commented May 12, 2016 • edited Loading

coveralls commented May 30, 2016 • edited Loading

guewen commented Jun 13, 2016

coveralls commented Jun 14, 2016 • edited Loading

atchuthan commented Jun 14, 2016

gurneyalex commented Jun 22, 2016

rafaelbn Jun 22, 2016

Choose a reason for hiding this comment

rafaelbn commented Jun 22, 2016

rousseldenis commented May 4, 2017

atchuthan commented May 8, 2017

rousseldenis commented May 8, 2017

coveralls commented May 12, 2016 •

edited

Loading

coveralls commented May 12, 2016 •

edited

Loading

guewen commented May 12, 2016 •

edited

Loading

coveralls commented May 12, 2016 •

edited

Loading

coveralls commented May 30, 2016 •

edited

Loading

coveralls commented Jun 14, 2016 •

edited

Loading