[17.0][MIG]sale_fixed_discount: Migrated module to v17.0 #2952
Conversation
instead of `sale.group_discount_per_so_line`
The sale order view in the portal was not displaying the fixed discount.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_fixed_discount/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_fixed_discount/pt_BR/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_fixed_discount/pt_BR/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_fixed_discount/es/
Currently translated at 100.0% (8 of 8 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_fixed_discount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_fixed_discount/it/
fd-oerp
force-pushed
the
17.0-sale-fixed-discount
branch
from
16fe8c6
to
761d41b
Compare
|
Hi @OCA-git-bot, can I have any update regarding this PR? |
fd-oerp
force-pushed
the
17.0-sale-fixed-discount
branch
from
f8a560e
to
409fe38
Compare
|
Hi @JordiBForgeFlow , could you please review this PR ? |
| * Jordi Ballester <jordi.ballester@forgeflow.com> (www.forgeflow.com) | ||
| * Pieter Paulussen <pieterpaulussen@code-source.be> (www.code-source.be) | ||
| - Lois Rilo <lois.rilo@forgeflow.com> | ||
| (`www.forgeflow.com <http://www.forgeflow.com>`__) |
There was a problem hiding this comment.
Hi @JordiBForgeFlow ,
if I chnage it to 'https' precommit fails and make it to 'http' by it self
I'm running precommit through : pre-commit run -a
would that be fine to commit it with 's' ?
There was a problem hiding this comment.
Does pre-commit give you any error message? which one is it?
There was a problem hiding this comment.
Hi @JordiBForgeFlow
Generate addons README files from fragments..............................Failed
- hook id: oca-gen-addon-readme
- files were modified by this hook
is this, and it update 'https' to 'http' by it self, still should I proceed with https ?
There was a problem hiding this comment.
Leave it for now and attend to my other comments, please.
| - Lois Rilo <lois.rilo@forgeflow.com> | ||
| (`www.forgeflow.com <http://www.forgeflow.com>`__) | ||
| - Jordi Ballester <jordi.ballester@forgeflow.com> | ||
| (`www.forgeflow.com <http://www.forgeflow.com>`__) |
| - Jordi Ballester <jordi.ballester@forgeflow.com> | ||
| (`www.forgeflow.com <http://www.forgeflow.com>`__) | ||
| - Pieter Paulussen <pieterpaulussen@code-source.be> | ||
| (`www.code-source.be <http://www.code-source.be>`__) |
|
Please merge your last two commits together using git rebase -i origin/17.0 |
[17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [IMP]Improved for discount when discount_fixed being 0/false [17.0][MIG]sale_fixed_discount: Migrated module to v17.0 [17.0][MIG]sale_fixed_discount: Migrated module to v17.0
fd-oerp
force-pushed
the
17.0-sale-fixed-discount
branch
from
2287d4d
to
dd0d82a
Compare
@JordiBForgeFlow commits are merged now |
|
/ocabot migration sale_fixed_discount |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 2dae613. Thanks a lot for contributing to OCA. ❤️ |
No description provided.