[FIX] sale_order_product_recommendation: make UoM work #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sergio-teruel, @rafaelbn, |
Before this patch, UoM wasn't being properly inherited into generated lines when those lines didn't exist previously in the SO. Also, changing it manually didn't work as expected in that same case. This is because the UoM was related to the SOL UoM. But if there was no SOL, it did nothing. Now it's properly computed. UoM comes from the product if there's no SOL or it can't provide it. The user can change it to other UoM of the same category. The change is propagated when applying the wizard, both when creating lines and updating them. Tests added. @moduon MT-4472
yajo
force-pushed
the
16.0-sale_order_product_recommendation-fix_missing_uom
branch
from
021283c
to
7f2c14f
Compare
Shide
approved these changes
Feb 15, 2024
EmilioPascual
approved these changes
Feb 15, 2024
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at fe1ffdc. Thanks a lot for contributing to OCA. ❤️ |
yajo
deleted the
16.0-sale_order_product_recommendation-fix_missing_uom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, UoM wasn't being properly inherited into generated lines when those lines didn't exist previously in the SO:
Also, changing it manually didn't work as expected in that same case.
This is because the UoM was related to the SOL UoM. But if there was no SOL, it did nothing.
Now it's properly computed. UoM comes from the product if there's no SOL or it can't provide it. The user can change it to other UoM of the same category. The change is propagated when applying the wizard, both when creating lines and updating them. Tests added.
@moduon MT-4472