[17.0] [MIG] sale_force_invoiced: migration to 17.0 #2961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] module 'sale_force_invoiced' for 9.0 * [FIX] Travis
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/de/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_force_invoiced/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_force_invoiced/ca/
Sometimes you have a SO that Odoo computes as "Nothing to invoice" but you want to force it to "Fully invoiced" anyway. Example: SO with 2 lines, line one is delivered and invoiced, second line is never going to be delivered nor invoiced ( because of different bussiness reasons). In this situation you still want to mark the SO as fully invoiced.
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_force_invoiced/fr/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/pt_BR/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/pt/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/fr/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/it/
Currently translated at 100.0% (3 of 3 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_force_invoiced Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_force_invoiced/de/
| @@ -21,6 +20,6 @@ class SaleOrder(models.Model): | |||
| def _compute_invoice_status(self): | |||
| res = super()._compute_invoice_status() | |||
| self.filtered( | |||
| lambda so: so.force_invoiced and so.state in ("sale", "done") | |||
| lambda so: so.force_invoiced and (so.state == "sale" or so.locked) | |||
There was a problem hiding this comment.
In principle, only orders in sale status can be locked. I think you can simplify the module by ignoring the locked field everywhere and just go by state sale. Note that orders in any other state will not be marked as invoiceable by Odoo: https://github.com/odoo/odoo/blob/3f6deca/addons/sale/models/sale_order.py#L530-L531 so even if orders were to be locked in any other status, this override might be considered meaningless for such orders. Or am i missing anything?
|
/ocabot migration sale_force_invoiced |
siemenv
force-pushed
the
17.0-mig-sale_force_invoiced
branch
from
5e3072c
to
c6e01d0
Compare
|
@JordiBForgeFlow @MiquelRForgeFlow @StefanRijnhart @siemenv I would say this module is quite dangerous and something has to be put in README. If a sale order is put as force invoiced and a line is added that generates a delivery order, the sale order won't never been invoiced for that outgoing product. |
|
Maybe a roadmap item can be added for a feature to ensure that only locked orders can be forced invoiced? @siemenv thanks for the update. Due to squashing, your commit message now has two lines: Only the first line is visible in the commit history here on Github. It must say Can you fix the commit message? |
siemenv
force-pushed
the
17.0-mig-sale_force_invoiced
branch
from
c6e01d0
to
705d0e6
Compare
|
/ocabot migration sale_force_invoiced |
StefanRijnhart
approved these changes
Mar 29, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 8c82f24. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.