[17.0][MIG] sale partner incoterm: Migration to 17.0 #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_partner_incoterm/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_partner_incoterm/de/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_partner_incoterm/zh_CN/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_partner_incoterm/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_partner_incoterm/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_partner_incoterm/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_partner_incoterm/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/ca/
Currently translated at 75.0% (3 of 4 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/nl/
Currently translated at 75.0% (3 of 4 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_partner_incoterm/
A field for incoterm address is added in partner model, this works as incoterm field
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_partner_incoterm/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_partner_incoterm/es/
Currently translated at 100.0% (6 of 6 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_partner_incoterm Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_partner_incoterm/it/
|
/ocabot migration sale_partner_incoterm |
1 similar comment
|
/ocabot migration sale_partner_incoterm |
| ) | ||
|
|
||
| @api.onchange("partner_id") | ||
| def onchange_partner_id_set_incoterm(self): |
There was a problem hiding this comment.
@StefanRijnhart As Odoo changed sale orders to full computed fields, shouldn't we use them too (store=True, readonly=False) ?
There was a problem hiding this comment.
I considered this at the time of migration, but the incoterm field is not owned by this module and adding a compute method for it does not scale to more than one module so I am not sure that is the best practice in this case. BTW there are plenty of leftover onchange methods in core Odoo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.