Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0][sale_packaging_price] Migrate to v9. #302

Merged
merged 18 commits into from
Sep 9, 2016

Conversation

yajo
Copy link
Member

@yajo yajo commented May 27, 2016

Migrate to v9.

  • Some view & menu IDs have been removed or changed.
  • LGPL, with original author permission.

@Tecnativa #223

@yajo yajo force-pushed the 9.0-sale_packaging_price-migration branch from bcb7549 to 57a0dbd Compare June 13, 2016 14:29
@yajo yajo force-pushed the 9.0-sale_packaging_price-migration branch 3 times, most recently from 35c9fe9 to 27b461a Compare June 15, 2016 10:56
Migrate to v9.

- Some view & menu IDs have been removed or changed.
- LGPL, with original author's permission.
@yajo yajo force-pushed the 9.0-sale_packaging_price-migration branch from 27b461a to e071feb Compare June 22, 2016 09:54
@rafaelbn rafaelbn added this to the 9.0 milestone Jul 15, 2016
To configure this module, you need to:

#. Go to *Warehouse > Configuration > Settings*.
#. Enable *Packages > Traceability > Record packages used on packing: pallets,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable Traceability > Packager > Record packager used on packing:pallets, boxes, ...

@rafaelbn
Copy link
Member

Thanks, some comments but 👍

from openerp.addons.decimal_precision import decimal_precision as dp


class ProductPackagingMaterial(models.Model):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be split in other file named product_packaging_material.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the main model here is product.packaging, so I will apply guidelines and rename to product_packaging.py, but it seems not splitting is justified this time.



class SaleOrderLine(models.Model):
_inherit = 'sale.order.line'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename should be sale_order_line.py

@@ -0,0 +1,27 @@
# -*- coding: utf-8 -*-
# (c) 2015 Antiun Ingeniería S.L. - Sergio Teruel
# (c) 2015 Antiun Ingeniería S.L. - Carlos Dauden
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change headers to © 2015 Carlos Dauden <carlos.dauden@tecnativa.com>

@carlosdauden
Copy link
Contributor

👍

@rafaelbn
Copy link
Member

rafaelbn commented Sep 9, 2016

Thanks 👍

@rafaelbn rafaelbn merged commit 0889b87 into OCA:9.0 Sep 9, 2016
@pedrobaeza pedrobaeza deleted the 9.0-sale_packaging_price-migration branch September 9, 2016 11:17
@rafaelbn
Copy link
Member

rafaelbn commented Sep 9, 2016

Sorry @carlosdauden I miss you comment. I make a PR for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants