[FIX] sale_advance_payment field amount_residual #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an error in the current version, when canceling a paid Invoice , It still sums up in the invoice_paid_amount , resulting in wrong amount_residual in sale order
rousseldenis
approved these changes
Apr 15, 2024
| @@ -86,7 +86,8 @@ def _compute_advance_payment(self): | |||
| for inv in order.invoice_ids.filtered( | |||
| lambda x: x.move_type == "out_invoice" | |||
| ): | |||
| invoice_paid_amount += inv.amount_total - inv.amount_residual | |||
| if inv.state == "posted": | |||
There was a problem hiding this comment.
How about we just add this condition in filtered instead of using both filtered and if?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error in the current version, when canceling a paid Invoice , It still sums up in the invoice_paid_amount , resulting in wrong amount_residual in sale order