[16.0][IMP][sale_order_lot_selection] allow or not change of lot_id

[Kev-Roche]

A lot / serial number can be selected on a sale order line and is propagated to related stock moves when the order is confirmed (through procurements)
But this lot / serial number can be modified after confirmation without propagation to stock moves.

We think we should make the lot / serial number field read-only after confirmation OR propagate the modification to related stock moves (if not already done)

The current PR add a config parameter to choose between these two strategies.

The "propagation" strategy implies another PR for the stock_restrict_lot module : OCA/stock-logistics-workflow#1560

Both @metaminux and me worked on this PR.

[OCA-git-bot]

Hi @bodedra,
some modules you are maintaining are being modified, check this out!

[rousseldenis]

Code review

[bodedra]

@Kev-Roche Generally, serial number related job done by Inventory user and manager. sale_order_lot_selection module empower the salesperson in this process and allows to sell it.

Here is my feedback:

If any change happens in the delivery process, it should be done from the Inventory side. In short, what is delivered, update it in the sale order. stock_move object has sale_line_id field. Thus, it is more manageable from the Inventory side rather than adding more responsibility in the salesperson.

At the end, customer wants their product, they don't care about serial number. ;-)

[antoniocanovas]

Functional review OK!!

[metaminux]

@antoniocanovas Thanks for your review

@bodedra I might not agree with your statement... In fact, choosing the lot / serial number in the SO is the purpose of sale_order_lot_selection and sometimes this choice can't be done before the SO is confirmed. So modifying the sale order line and propagating this change to delivery and production for example is what users need or want.

Could you please reconsider this PR ?