[FIX] sale_triple_discount: apply rounding #3061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaniszewska-dev
force-pushed
the
triple_discount_rounding_fix
branch
from
9e3bf88
to
ca1a582
Compare
JuMiSanAr
approved these changes
Apr 10, 2024
| @@ -58,7 +58,8 @@ def _multiplicative_discount(self): | |||
| final_discount = 1 | |||
| for discount in discounts: | |||
| final_discount *= discount | |||
| return 100 - final_discount * 100 | |||
| result = 100 - final_discount * 100 | |||
| return round(result, 3) | |||
There was a problem hiding this comment.
@ajaniszewska-dev Why 3 (and not another number ...)?
There was a problem hiding this comment.
IMHO, you should (at least) use the configuration one:
There was a problem hiding this comment.
@rousseldenis thank you for remark, corrected code.
ajaniszewska-dev
force-pushed
the
triple_discount_rounding_fix
branch
from
f548e23
to
9b827eb
Compare
ajaniszewska-dev
force-pushed
the
triple_discount_rounding_fix
branch
from
9b827eb
to
d074776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes in case of multiplicative discount, subtotal on the line is not same as untaxed amount. Seems due to rounding as so far result returned by method could be something like:
284.64151515before:
after:
