[17.0][MIG] sale cancel reason #3062

maciej-wichowski · 2024-04-09T11:38:57Z

No description provided.

(../trunk-generic/ rev 29.1.1)

(../trunk-generic/ rev 32.1.1)

(../trunk-generic/ rev 32.1.2)

- Update travis.yml to 8.0

Only hide button instead of renaming it

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

… of sale_cancel_reason module

* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2

Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/

celm1990

Could you add a Reason field to this wizard?

celm1990 · 2024-04-09T13:29:14Z

sale_cancel_reason/wizard/cancel_reason_view.xml

+                        sale order.
+                    </p>
+                    <group>
+                        <field name="reason_id" widget="selection" />


Please remove the selection widget. With many records, filtering becomes complicated, and not all records are displayed.

Suggested change

<field name="reason_id" widget="selection" />

<field name="reason_id" options="{'no_create': True, 'no_open': True}" />

maciej-wichowski · 2024-04-09T15:09:18Z

Hello @celm1990 , thank you for your review! I added possibility to choose cancel reason on mass quotation cancel wizard.
Regarding removing selection widget: I don't think we should make such improvements during module migration. I suggest to create an Issue in this repo to properly discuss your suggestion with the maintainers.

rousseldenis · 2024-04-11T09:55:56Z

/ocabot migration sale_cancel_reason

rousseldenis · 2024-04-11T09:56:36Z

sale_cancel_reason/__manifest__.py

@@ -5,7 +5,7 @@

 {
    "name": "Sale Cancel Reason",
-    "version": "16.0.1.0.1",
+    "version": "17.0.1.0.1",


Usually we reset to 17.0.1.0.0

rousseldenis

Minor remark

celm1990

For consistency, both wizard fields must be the same (either many2one with widget=selection or not)

celm1990 · 2024-04-11T13:37:37Z

sale_cancel_reason/wizard/mass_cancel_orders_view.xml

+        <field name="arch" type="xml">
+            <footer position="before">
+                <group>
+                    <field name="reason_id" />


Suggested change

<field name="reason_id" />

<field name="reason_id" options="{'no_create': True, 'no_open': True}"/>

Forgot about it, thanks.

celm1990

I think these two commits can be squashed into a single commit

OCA-git-bot · 2024-04-15T09:53:00Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

maciej-wichowski · 2024-04-15T12:26:48Z

@rousseldenis , since it's approved, could you merge?

rousseldenis · 2024-04-15T15:41:36Z

I think these two commits can be squashed into a single commit

@celm1990 FYI, if the commit is reflecting an improvement or is not related to the preceding one (migration), it's common to let them in place. As maybe, it can be easily forward/backported.

rousseldenis · 2024-04-15T15:42:08Z

/ocabot merge nobump

OCA-git-bot · 2024-04-15T15:42:17Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3062-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2024-04-15T15:48:44Z

Congratulations, your PR was merged at 2149146. Thanks a lot for contributing to OCA. ❤️

guewen and others added 30 commits April 9, 2024 13:16

[MRG] from master branch

1f4cc61

(../trunk-generic/ rev 29.1.1)

[FIX] sale cancel reason dependence

c7eb499

(../trunk-generic/ rev 32.1.1)

[FIX] sale_cancel_reason: remove dependency on sale_stock

d384744

(../trunk-generic/ rev 32.1.2)

spellcheck

53a95ca

[FIX] repository PEP8

e08ed09

[FIX] Still some PEP8 erros

59420b0

- Set as uninstallable and moved to __unported__ dir all modules.

c75ce57

- Update travis.yml to 8.0

reactivate sale_cancel_reason

a524859

port models and method to api 8.0

82f9493

Improve override of cancel button to ease inheritance of view

ca8d2d1

Only hide button instead of renaming it

[FIX] typo on class name

6c4772b

Add OCA as author of OCA addons

47626c7

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Added Finnish translations

1c7b7aa

[FIX] cancel button of orignal view should be hide after installation…

b8fad5e

… of sale_cancel_reason module

Add missing default oca icons

7170faf

Slovene translations added

e00fa84

bump version of sale_cancel_reason

81c103e

OCA Transbot updated translations from Transifex

c8b16f6

[MIG] Make modules uninstallable

4ec2a71

[FIX] remove en.po that was erroneously created by transbot

042b622

[MIG] Rename manifest files

fb34553

[MIG] sale_cancel_reason Migration to 10.0 (OCA#477)

a44f7a5

* [MIG] sale_cancel_reason Migration to 10.0 * Follow coding standard * Convert test to unittest2

remove obsolete .pot files [ci skip]

334b6ba

[UPD] Update sale_cancel_reason.pot

4fb889c

Update translation files

21a22d4

Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate.

Translated using Weblate (Portuguese)

cd7010c

Currently translated at 100.0% (23 of 23 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_cancel_reason/pt/

[MIG] sale_cancel_reason: Migration to 12.0

e1f04c5

[UPD] README.rst

1f08fb4

[UPD] Update sale_cancel_reason.pot

4971e66

Update translation files

7bab533

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_cancel_reason Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_cancel_reason/

celm1990 suggested changes Apr 9, 2024

View reviewed changes

maciej-wichowski force-pushed the 17.0-mig-sale_cancel_reason branch from 61340f5 to b6b1615 Compare April 9, 2024 15:05

maciej-wichowski requested a review from celm1990 April 9, 2024 15:09

OCA-git-bot added this to the 17.0 milestone Apr 11, 2024

rousseldenis added needs review migration labels Apr 11, 2024

rousseldenis reviewed Apr 11, 2024

View reviewed changes

rousseldenis approved these changes Apr 11, 2024

View reviewed changes

celm1990 suggested changes Apr 11, 2024

View reviewed changes

maciej-wichowski force-pushed the 17.0-mig-sale_cancel_reason branch 2 times, most recently from 866d216 to 4be9715 Compare April 11, 2024 15:12

maciej-wichowski requested a review from celm1990 April 11, 2024 15:12

celm1990 approved these changes Apr 11, 2024

View reviewed changes

OCA-git-bot added the approved label Apr 11, 2024

[MIG] sale_cancel_reason: migration to 17.0

2d15d00

maciej-wichowski force-pushed the 17.0-mig-sale_cancel_reason branch from 4be9715 to 2d15d00 Compare April 11, 2024 15:23

OCA-git-bot added the ready to merge label Apr 15, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 15, 2024

OCA-git-bot merged commit 454272e into OCA:17.0 Apr 15, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 15, 2024

maciej-wichowski deleted the 17.0-mig-sale_cancel_reason branch April 16, 2024 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] sale cancel reason #3062

[17.0][MIG] sale cancel reason #3062

maciej-wichowski commented Apr 9, 2024

celm1990 left a comment

celm1990 Apr 9, 2024

maciej-wichowski commented Apr 9, 2024

rousseldenis commented Apr 11, 2024

rousseldenis Apr 11, 2024

rousseldenis left a comment

celm1990 left a comment

celm1990 Apr 11, 2024

maciej-wichowski Apr 11, 2024

celm1990 left a comment

OCA-git-bot commented Apr 15, 2024

maciej-wichowski commented Apr 15, 2024

rousseldenis commented Apr 15, 2024

rousseldenis commented Apr 15, 2024

OCA-git-bot commented Apr 15, 2024

OCA-git-bot commented Apr 15, 2024

	<field name="reason_id" widget="selection" />
	<field name="reason_id" options="{'no_create': True, 'no_open': True}" />

	<field name="reason_id" />
	<field name="reason_id" options="{'no_create': True, 'no_open': True}"/>

[17.0][MIG] sale cancel reason #3062

[17.0][MIG] sale cancel reason #3062

Conversation

maciej-wichowski commented Apr 9, 2024

celm1990 left a comment

Choose a reason for hiding this comment

celm1990 Apr 9, 2024

Choose a reason for hiding this comment

maciej-wichowski commented Apr 9, 2024

rousseldenis commented Apr 11, 2024

rousseldenis Apr 11, 2024

Choose a reason for hiding this comment

rousseldenis left a comment

Choose a reason for hiding this comment

celm1990 left a comment

Choose a reason for hiding this comment

celm1990 Apr 11, 2024

Choose a reason for hiding this comment

maciej-wichowski Apr 11, 2024

Choose a reason for hiding this comment

celm1990 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 15, 2024

maciej-wichowski commented Apr 15, 2024

rousseldenis commented Apr 15, 2024

rousseldenis commented Apr 15, 2024

OCA-git-bot commented Apr 15, 2024

OCA-git-bot commented Apr 15, 2024