Do not use computed value for new computation #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| line = self._get_interest_line() | ||
| if line: | ||
| for line in [line for line in self.order_line | ||
| if not line.interest_line]: |
There was a problem hiding this comment.
To keep the modularity you could change the condition to if not line == self._get_interest_line()
|
@guewen corrected, thanks for the review |
|
Thanks 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a small "edge case" I had with a customer : basically, the line's old value was used to recompute the value itself.
In that particular case, the taxes and total amount made it so that the small amount variation was over/under 3.815, which meant that:
That means, in the method https://github.com/OCA/sale-workflow/blob/8.0/sale_payment_term_interest/model/sale_order.py#L99 , the 2 values were always different by 0.01.
The fix is straight-forward : instead of substracting the interest line's amount to the total amount, all non-interest lines are added (meaning the value used as a basis remains constant).