Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][8.0] Sale procurement group by requested date #320

Conversation

AaronHForgeFlow
Copy link
Contributor

Sale Procurement Group by Requested date

This module creates different procurements groups for different requested dates in a sale order line when the sale order is confirmed. It depends on sale_sourced_by_line so this module will group procurements also by the warehouse in the sale order_line.

Installation

This module depends on the modules sale_procurement_group_by_line and
sale_sourced_by_line.

Configuration

No special configuration is required.

Usage

  • Add a requested date for a sale order line.
  • Confirmthe sale order

@StefanRijnhart StefanRijnhart added this to the 8.0 milestone Sep 28, 2016
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only two small requests in my review

@api.multi
def _get_procurement_group_key(self):
""" Return a key with priority to be used to regroup lines in multiple
procurement groups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add to the docstring how the priority is determined by the super?

This module creates different procurements groups for different requested
dates in a sale order line when the sale order is confirmed.
It depends on sale_sourced_by_line so this module will group procurements
the warehosue in the sale order_line also.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'warehouse'

@AaronHForgeFlow AaronHForgeFlow force-pushed the 8.0-sale_procurement_group_by_requested_date branch from 8bbadbc to ab9d1f3 Compare June 14, 2017 08:32
@AaronHForgeFlow
Copy link
Contributor Author

AaronHForgeFlow commented Jun 14, 2017

@StefanRijnhart I'm sorry for the late review

Camille0907 pushed a commit to Camille0907/sale-workflow that referenced this pull request Jan 26, 2022
Signed-off-by sbidoul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants