[ADD][8.0]sale_order_line_date #323

AaronHForgeFlow · 2016-08-02T14:27:22Z

Sale order line date

This module adds requested date to a sales order lines and propagate it to
stock moves and procurement.

When the requested date of the whole sale order is modified the requested date
of the lines change to match.

Usage

Add a requested date for a sale order line. Confirm the sale. The scheduled date of the procurement will be the same as in the sale order line.

oca-clabot · 2016-08-02T14:27:24Z

Hey @aheficent, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@esthermm (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

oca-clabot · 2016-08-26T10:12:19Z

Hey @aheficent,
We acknowledge that the following users have signed our Contributor License Agreement:

@esthermm

Appreciation of efforts,
OCA CLAbot

StefanRijnhart · 2016-09-28T16:41:00Z

sale_order_line_dates/README.rst

+
+
+This module adds requested date to a sales order lines and propagate it to
+stock moves and procurements


Can you clarify how this relates to the sale order's requested_date field from sale_order_dates?

Done. Thank you @StefanRijnhart

StefanRijnhart · 2016-09-28T16:41:46Z

Thank you. Your branch has merge commits. Either you can rebase now or we should rebase or squash at merge time.

susport

Please to correct the travis error.

susport · 2016-12-07T22:18:06Z

sale_order_line_dates/models/sale_order.py

+# © 2015 Eficent Business and IT Consulting Services, S.L.
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from openerp import models, fields, api


Order by name the import, about OCA guide

pedrobaeza · 2016-12-07T22:54:23Z

Put the module name in singular according OCA guidelines.

andhit-r · 2016-12-09T01:11:39Z

@pedrobaeza i notice that this module migrate from odoomrp-wip. Name changes will affect database that already has sale_order_line_dates. Changes according OCA guidelines is unavoidable, but would you kindly point me any doc on how to correct this issue. Are these docs enough:

Many thanks

AaronHForgeFlow · 2016-12-20T13:53:17Z

According to that I should add some migrations scripts to rename the columns related to the module name. Shouldn't I?

JordiBForgeFlow · 2016-12-20T14:13:14Z

Hi, if the names of the modules do not change, I guess that you can install the new module, and the uninstall the old one once the first has been installed. El 20 dic. 2016 2:53 p. m., "Aarón Henríquez" <notifications@github.com> escribió:

…

According to that I should add some migrations scripts to rename the columns related to the module name. Shouldn't I? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#323 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHU_Vj7bqfNS4ByTie7D6bSbRVDNk_TDks5rJ93PgaJpZM4Jaqti> .

pedrobaeza · 2016-12-20T15:29:48Z

You can use openupgradelib for updating a module name in case you have an installation with old OdooMRP module. In case of migrating to another version, OpenUpgrade can also help, but that's not the case.

AaronHForgeFlow · 2016-12-20T15:33:18Z

All right @pedrobaeza Thank you for the explanation

JordiBForgeFlow · 2016-12-21T12:10:48Z

sale_order_line_date/README.rst

+* Jordi Ballester <jordi.ballester@eficent.com>
+* Aaron Henriquez <ahenriquez@eficent.com>
+
+Maintainer


Please change as per latest OCA template: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst#maintainer

rafaelbn · 2016-12-21T13:38:53Z

Do you know why runbot is 💔 ?

AaronHForgeFlow · 2016-12-21T14:04:17Z

I can run it but I cannot see the logs. Strange.

AaronHForgeFlow · 2016-12-22T10:01:00Z

I tested on runbot and I got an error when duplicating a sales order:

May it be related to this issue: #304 ?

serpentcs-dev1 · 2017-05-15T05:17:19Z

sale_order_line_date/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/213/8.0


Repo id is improper: https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt#L81

MiquelRForgeFlow

Please, squash commits 🙂

[MOD] <sale_order_line_dates> working onchange [MOD] <sale_order_line_dates> fixed pep8 error [FIX] sale_order_line_dates: Avoid expected singleton on onchange [FIX] If sale.order fields are datetime in line it must also be

[IMP] Solve bug when line's requested_date was empty

[FIX] Update readme to latest template

AaronHForgeFlow · 2017-06-22T11:29:52Z

Done @mreficent 🎸

LoisRForgeFlow · 2017-08-28T13:29:40Z

@StefanRijnhart @darshan-serpent @susport could you please update your reviews?

serpentcs-dev1

LGTM 👍

StefanRijnhart reviewed Sep 28, 2016

View reviewed changes

StefanRijnhart added the needs review label Sep 28, 2016

StefanRijnhart added this to the 8.0 milestone Sep 28, 2016

susport reviewed Nov 26, 2016

View reviewed changes

susport reviewed Dec 7, 2016

View reviewed changes

AaronHForgeFlow force-pushed the 8.0-sale_order_line_dates branch from c53ada6 to 9bc6887 Compare December 20, 2016 13:35

AaronHForgeFlow changed the title ~~[ADD][8.0] sale order line dates~~ [ADD][8.0]sale_order_line_date Dec 20, 2016

AaronHForgeFlow force-pushed the 8.0-sale_order_line_dates branch 2 times, most recently from 5a56ae6 to 2c47843 Compare December 21, 2016 11:03

AaronHForgeFlow closed this Dec 21, 2016

AaronHForgeFlow reopened this Dec 21, 2016

JordiBForgeFlow requested changes Dec 21, 2016

View reviewed changes

AaronHForgeFlow force-pushed the 8.0-sale_order_line_dates branch from a116ff2 to d08f109 Compare December 21, 2016 12:41

JordiBForgeFlow approved these changes Dec 21, 2016

View reviewed changes

serpentcs-dev1 reviewed May 15, 2017

View reviewed changes

AaronHForgeFlow force-pushed the 8.0-sale_order_line_dates branch 2 times, most recently from e5c3b8f to b11b5a6 Compare June 14, 2017 08:49

MiquelRForgeFlow approved these changes Jun 22, 2017

View reviewed changes

oihane and others added 3 commits June 22, 2017 13:26

[MOD] <sale_order_line_dates> propagate requested_date to stock moves

b717451

[IMP] Solve bug when line's requested_date was empty

[UPT] Update code

92e1e9f

[FIX] Update readme to latest template

AaronHForgeFlow force-pushed the 8.0-sale_order_line_dates branch from b11b5a6 to 92e1e9f Compare June 22, 2017 11:27

serpentcs-dev1 approved these changes Aug 28, 2017

View reviewed changes

JordiBForgeFlow merged commit 16d888b into OCA:8.0 Aug 28, 2017

LoisRForgeFlow deleted the 8.0-sale_order_line_dates branch August 29, 2017 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][8.0]sale_order_line_date #323

[ADD][8.0]sale_order_line_date #323

AaronHForgeFlow commented Aug 2, 2016 •

edited

Loading

oca-clabot commented Aug 2, 2016

oca-clabot commented Aug 26, 2016

StefanRijnhart Sep 28, 2016

AaronHForgeFlow Dec 20, 2016

StefanRijnhart commented Sep 28, 2016

susport left a comment

susport Dec 7, 2016

pedrobaeza commented Dec 7, 2016

andhit-r commented Dec 9, 2016 •

edited

Loading

AaronHForgeFlow commented Dec 20, 2016

JordiBForgeFlow commented Dec 20, 2016 via email

pedrobaeza commented Dec 20, 2016

AaronHForgeFlow commented Dec 20, 2016

JordiBForgeFlow Dec 21, 2016

rafaelbn commented Dec 21, 2016

AaronHForgeFlow commented Dec 21, 2016

AaronHForgeFlow commented Dec 22, 2016

serpentcs-dev1 May 15, 2017

MiquelRForgeFlow left a comment

AaronHForgeFlow commented Jun 22, 2017

LoisRForgeFlow commented Aug 28, 2017

serpentcs-dev1 left a comment



		This module adds requested date to a sales order lines and propagate it to
		stock moves and procurements

[ADD][8.0]sale_order_line_date #323

[ADD][8.0]sale_order_line_date #323

Conversation

AaronHForgeFlow commented Aug 2, 2016 • edited Loading

Sale order line date

Usage

oca-clabot commented Aug 2, 2016

oca-clabot commented Aug 26, 2016

StefanRijnhart Sep 28, 2016

Choose a reason for hiding this comment

AaronHForgeFlow Dec 20, 2016

Choose a reason for hiding this comment

StefanRijnhart commented Sep 28, 2016

susport left a comment

Choose a reason for hiding this comment

susport Dec 7, 2016

Choose a reason for hiding this comment

pedrobaeza commented Dec 7, 2016

andhit-r commented Dec 9, 2016 • edited Loading

AaronHForgeFlow commented Dec 20, 2016

JordiBForgeFlow commented Dec 20, 2016 via email

pedrobaeza commented Dec 20, 2016

AaronHForgeFlow commented Dec 20, 2016

JordiBForgeFlow Dec 21, 2016

Choose a reason for hiding this comment

rafaelbn commented Dec 21, 2016

AaronHForgeFlow commented Dec 21, 2016

AaronHForgeFlow commented Dec 22, 2016

serpentcs-dev1 May 15, 2017

Choose a reason for hiding this comment

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

AaronHForgeFlow commented Jun 22, 2017

LoisRForgeFlow commented Aug 28, 2017

serpentcs-dev1 left a comment

Choose a reason for hiding this comment

AaronHForgeFlow commented Aug 2, 2016 •

edited

Loading

andhit-r commented Dec 9, 2016 •

edited

Loading