-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD][8.0]sale_order_line_date #323
Conversation
Hey @aheficent, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
Hey @aheficent, Appreciation of efforts, |
sale_order_line_dates/README.rst
Outdated
|
||
|
||
This module adds requested date to a sales order lines and propagate it to | ||
stock moves and procurements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify how this relates to the sale order's requested_date field from sale_order_dates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you @StefanRijnhart
Thank you. Your branch has merge commits. Either you can rebase now or we should rebase or squash at merge time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please to correct the travis error.
# © 2015 Eficent Business and IT Consulting Services, S.L. | ||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
|
||
from openerp import models, fields, api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order by name the import, about OCA guide
Put the module name in singular according OCA guidelines. |
@pedrobaeza i notice that this module migrate from odoomrp-wip. Name changes will affect database that already has sale_order_line_dates. Changes according OCA guidelines is unavoidable, but would you kindly point me any doc on how to correct this issue. Are these docs enough:
Many thanks |
c53ada6
to
9bc6887
Compare
According to that I should add some migrations scripts to rename the columns related to the module name. Shouldn't I? |
Hi, if the names of the modules do not change, I guess that you can install
the new module, and the uninstall the old one once the first has been
installed.
El 20 dic. 2016 2:53 p. m., "Aarón Henríquez" <notifications@github.com>
escribió:
… According to that I should add some migrations scripts to rename the
columns related to the module name. Shouldn't I?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHU_Vj7bqfNS4ByTie7D6bSbRVDNk_TDks5rJ93PgaJpZM4Jaqti>
.
|
You can use openupgradelib for updating a module name in case you have an installation with old OdooMRP module. In case of migrating to another version, OpenUpgrade can also help, but that's not the case. |
All right @pedrobaeza Thank you for the explanation |
5a56ae6
to
2c47843
Compare
* Jordi Ballester <jordi.ballester@eficent.com> | ||
* Aaron Henriquez <ahenriquez@eficent.com> | ||
|
||
Maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change as per latest OCA template: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst#maintainer
a116ff2
to
d08f109
Compare
Do you know why runbot is 💔 ? |
I can run it but I cannot see the logs. Strange. |
I tested on runbot and I got an error when duplicating a sales order: May it be related to this issue: #304 ? |
sale_order_line_date/README.rst
Outdated
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/213/8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repo id is improper: https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt#L81
e5c3b8f
to
b11b5a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, squash commits 🙂
[MOD] <sale_order_line_dates> working onchange [MOD] <sale_order_line_dates> fixed pep8 error [FIX] sale_order_line_dates: Avoid expected singleton on onchange [FIX] If sale.order fields are datetime in line it must also be
[IMP] Solve bug when line's requested_date was empty
[FIX] Update readme to latest template
b11b5a6
to
92e1e9f
Compare
Done @mreficent 🎸 |
@StefanRijnhart @darshan-serpent @susport could you please update your reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sale order line date
This module adds requested date to a sales order lines and propagate it to
stock moves and procurement.
When the requested date of the whole sale order is modified the requested date
of the lines change to match.
Usage
Add a requested date for a sale order line. Confirm the sale. The scheduled date of the procurement will be the same as in the sale order line.