[10.0] Port sale_validity to v10 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert YAML tests to unittests Add README.rst
legalsylvain
approved these changes
Mar 9, 2017
There was a problem hiding this comment.
Hi @alexis-via . Thanks for porting this module.
👍
Just one thing, for the next time, please use git mv command when you rename the files. Otherwise, it's a mess to review changes.
kind regards.
|
@legalsylvain I used "git mv" ! I guess it's because the files are both renamed and changed... |
|
Ow ! Maybe yes. In that case, 2 commits (one for all the renames, and one for the real changes could make review more easy). regards. |
LoisRForgeFlow
approved these changes
Apr 11, 2017
|
@lreficent I don't use v9 so I don't plan to backport it myself, but feel free to do it. It should be very easy to backport. |
JordiBForgeFlow
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New use the native field from the sale module
Convert YAML tests to unittests
Add README.rst