8.0 sale_sourced_by_line - Fix is_shipped method #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
changed the title
|
👍 |
|
a "check" method like that, with many corner cases, is a good candidate for isolated unit tests (i.e. not full stories). It can probably be tested without too much effort with the shiny |
|
I've tested it, it works. I'm in favor of having a test here. This is an important feature for invoicing process. After that, you get my 👍 |
|
I have some tests ready on https://github.com/yvaucher/sale-workflow/tree/8.0-fix-sale_sourced_by_line-is_delivered-add-tests But is it stalled because of: odoo/odoo#3922 |
|
I see @yvaucher . I am merging this one, you can create a PR for the tests that are stalled. Thanks! |
lepistone
added a commit
that referenced
this pull request
Dec 1, 2014
…delivered 8.0 sale_sourced_by_line - Fix is_shipped method
SerpentCS
pushed a commit
to SerpentCS/sale-workflow
that referenced
this pull request
Feb 20, 2017
…is_delivered 8.0 sale_sourced_by_line - Fix is_shipped method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give positive attitude to method is_shipped which was always False.