Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][ADD] Add behavior to auto-fill the automatic workflow with the payment mode (like sale order) #932

Merged
merged 1 commit into from Nov 8, 2019

Conversation

acsonefho
Copy link
Contributor

Exactly as the sale order, the automatic workflow of the invoice should be automatically set depending on the payment mode.

@acsonefho acsonefho changed the title WIP [10.0][ADD] Add behavior to auto-fill the automatic workflow with the payment mode (like sale order) [10.0][ADD] Add behavior to auto-fill the automatic workflow with the payment mode (like sale order) Sep 13, 2019
@rafaelbn rafaelbn added this to the 10.0 milestone Sep 22, 2019
@rafaelbn
Copy link
Member

Hi @acsonefho , please could you review why travis fail 🔴 ? thank you!

@acsonefho acsonefho force-pushed the 10.0-automatic_workflow_invoice branch 2 times, most recently from 93288e8 to 4e3073a Compare September 24, 2019 06:21
@Cedric-Pigeon
Copy link
Contributor

@rafaelbn this one is green now.

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

<field name="inherit_id" ref="account.invoice_form"/>
<field name="priority" eval="95"/>
<field name="arch" type="xml">
<field name="payment_mode_id" position="after">
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acsonefho This should go to sale_automatic_workflow_payment_mode module

@rousseldenis rousseldenis force-pushed the 10.0-automatic_workflow_invoice branch from b107674 to 33a4a18 Compare November 5, 2019 15:49
@rousseldenis
Copy link
Sponsor Contributor

@rafaelbn This one is green 🍏

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

@OCA/crm-sales-marketing-maintainers

@rafaelbn
Copy link
Member

rafaelbn commented Nov 8, 2019

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-932-by-rafaelbn-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 8, 2019
Signed-off-by rafaelbn
@OCA-git-bot OCA-git-bot merged commit 33a4a18 into OCA:10.0 Nov 8, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8e60441. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants