Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] product_supplierinfo_for_customer_sale #976

Merged

Conversation

MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Oct 24, 2019

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-product_supplierinfo_for_customer_sale branch 5 times, most recently from 26121cc to 763995a Compare October 28, 2019 14:27
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just functional tests 👍

AaronHForgeFlow and others added 22 commits November 14, 2019 13:04
[REF] product_supplierinfo_for_customer_sale: Changes in test.

[REF] product_supplierinfo_for_customer_sale: Complete README.rst
…rch, products found by default code and customer code

[REF] product_supplierinfo_for_customer_sale: Add test to find more than one product in name_search

[REF] product_supplierinfo_for_customer_sale: In test find one product from customer code and other one from product default code.

[REF] product_supplierinfo_for_customer_sale: Changes in name_search to work exactly with number of limit defined.

[REF] product_supplierinfo_for_customer_sale: Changes in name_search
 - New field name from type to supplierinfo_type
 - Remove copyright for __init__.py
 - Re-using variables from tests
 - Manifest bump version and using module url
 - Get commit history from
 https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_sale
    - Run 2to3 script
    - view fixing
… instead of manual assign.

 - Removing duplicated test for name_search
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
There's no price computation on the module, so there shouldn't be any test regarding
this topic, or it can fail in integration tests.
Currently translated at 11.1% (1 of 9 strings)

Translation: sale-workflow-11.0/sale-workflow-11.0-product_supplierinfo_for_customer_sale
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-11-0/sale-workflow-11-0-product_supplierinfo_for_customer_sale/de/
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-mig-product_supplierinfo_for_customer_sale branch from 763995a to 10ce1a2 Compare November 14, 2019 12:04
Copy link
Contributor

@AdriaGForgeFlow AdriaGForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@AaronHForgeFlow
Copy link
Contributor

Ready to merge

@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-976-by-jbeficent-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 26, 2019
Signed-off-by jbeficent
@OCA-git-bot OCA-git-bot merged commit 10ce1a2 into OCA:12.0 Nov 26, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 82a1cd2. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 12.0-mig-product_supplierinfo_for_customer_sale branch November 26, 2019 13:18
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 17, 2020
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet