[IMP] connector_search_engine: check binding model

OCA · Dec 1, 2023 · 02013d1 · 02013d1
1 parent d29f007
commit 02013d1
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/connector_search_engine/models/se_binding.py b/connector_search_engine/models/se_binding.py
@@ -85,6 +85,17 @@ class SeBinding(models.Model):
         ),
     ]
 
+    @api.constrains("res_model", "index_id")
+    def _check_model(self):
+        for binding in self:
+            if (
+                binding.res_model
+                and binding.res_model != binding.index_id.model_id.model
+            ):
+                raise ValidationError(
+                    _("Binding model must be equal to the index model")
+                )
+
     @tools.ormcache()
     @api.model
     def _get_indexable_model_selection(self):

diff --git a/connector_search_engine/tests/models.py b/connector_search_engine/tests/models.py
@@ -88,3 +88,8 @@ def _get_serializer(self):
 class ResPartner(models.Model):
     _name = "res.partner"
     _inherit = ["res.partner", "se.indexable.record"]
+
+
+class ResUsers(models.Model):
+    _name = "res.users"
+    _inherit = ["res.users", "se.indexable.record"]
diff --git a/connector_search_engine/tests/test_all.py b/connector_search_engine/tests/test_all.py
@@ -5,6 +5,7 @@
 
 from odoo_test_helper import FakeModelLoader
 
+from odoo.exceptions import ValidationError
 from odoo.tests.common import Form
 from odoo.tools import mute_logger
 
@@ -25,11 +26,12 @@ def setUpClass(cls):
             FakeSeAdapter,
             FakeSerializer,
             ResPartner,
+            ResUsers,
             SeBackend,
             SeIndex,
         )
 
-        cls.loader.update_registry((ResPartner, SeBackend, SeIndex))
+        cls.loader.update_registry((ResPartner, ResUsers, SeBackend, SeIndex))
         cls.binding_model = cls.env["se.binding"]
         cls.se_index_model = cls.env["se.index"]
 
@@ -381,3 +383,9 @@ def test_binding_multi_backend_index(self):
         self.assertEqual(self.partner_binding.mapped("state"), ["done"])
         bindings.delete_record()
         self.assertFalse(self.partner_binding.exists())
+
+    def test_binding_wrong_model(self):
+        # Try to add a 'res.users' record to a 'res.partner' index
+        user = self.env["res.users"].search([], limit=1)
+        with self.assertRaises(ValidationError):
+            user._add_to_index(self.se_index)