Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing button export_settings #167

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented Nov 8, 2023

No description provided.

@MrTango
Copy link
Contributor Author

MrTango commented Nov 8, 2023

@sebastienbeau please review

@MrTango MrTango mentioned this pull request Nov 8, 2023
3 tasks
name="export_settings"
role="menuitem"
class="dropdown-item"
help="Force the export of all binding"
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help text is not the right one...

Copy link
Sponsor Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrTango Thank you for the contrib. A little comment...

name="export_settings"
role="menuitem"
class="dropdown-item"
help="Force the export of all binding"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
help="Force the export of all binding"
help="Update or initialize index settings"

@bealdav
Copy link
Member

bealdav commented Jan 18, 2024

Fixed by #188 cc @lmignon @simahawk

@lmignon
Copy link
Sponsor Contributor

lmignon commented Jan 23, 2024

Superseded by #188 where the last comment has been taken into account.

@lmignon lmignon closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants