[15.0][MIG] auth_jwt: Migration to 15.0

[yankinmax]

No description provided.

[yankinmax]

@sbidoul can we proceed here?

[sbidoul]

Oh, and same for the re-licensing to LGPL. I agree to do it but this should be in a separate commit or PR for easier backporting - this is not a migration commit.

[sbidoul]

Ah and can you migrate auth_jwt_demo in the same PR so we have all the tests at once ?

[yankinmax]

@sbidoul having error:

eslint...................................................................Failed
- hook id: eslint
- duration: 0.32s
- exit code: 1


odoo/external-src/server-auth/auth_jwt_demo/tests/spa/js/app.js
  1:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

odoo/external-src/server-auth/auth_jwt_demo/tests/spa/js/oidc-client.js
  5:1  error  Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

✖ 2 problems (2 errors, 0 warnings)

Tried to change ecmaVersion: 2020 and es2020: true. Didn't help. Any idea?
Updated: same on pre-commit check.

[sbidoul]

@yankinmax could you try renaming app.js to app.esm.js (also in index.html)

[yankinmax]

@sbidoul pre-commit check is twice canceled. What can we do here to continue?

[yankinmax]

@simahawk can you take a look pls here?

[simahawk]

@yankinmax what I would do:

1. move license change to v14, merge there quickly and get back to 15
2. open a PR w/ the module set as uninstallable for 15 and merge quickly
3. rebase this one or open a new one for the migration

While doing so, use separated commits for improvements like #316 (comment)
This way reviewing the migration will be much easier and back porting of improvements too.

[simahawk]

license updated on v14 here #319

[yankinmax]

@sbidoul can we proceed here?

[sbidoul]

I'm confused. What is the difference between #320 and this one ?

[yankinmax]

@sbidoul #320 is needed to port auth_jwt and auth_jwt_demo from v14 to v15 without any changes.
Then, when #320 will be merged I'll rebase this one and do only two commits for migration.
This helps us to avoid not related to migration commits (all these mess during review).
So, ATM pls merge #320

[sbidoul]

/ocabot migration auth_jwt

[sbidoul]

/ocabot migration auth_jwt_demo

[yankinmax]

@sbidoul I rebased this PR. Get too many eslint errors on pre-commit. Should we fix them all?

[lmignon]

@yankinmax IMO we should ignore the file auth_jwt_demo/tests/spa/js/oidc-client.esm.js into the pre-commit checks by modifying the .pre-commit-config.yaml file.

- repo: https://github.com/pre-commit/mirrors-eslint
    rev: v7.32.0
    hooks:
      - id: eslint
        verbose: true
        args:
          - --color
          - --fix
        exclude: auth_jwt_demo/tests/spa/js/oidc-client.esm.js

[yankinmax]

@yankinmax IMO we should ignore the file auth_jwt_demo/tests/spa/js/oidc-client.esm.js into the pre-commit checks by modifying the .pre-commit-config.yaml file.

- repo: https://github.com/pre-commit/mirrors-eslint
    rev: v7.32.0
    hooks:
      - id: eslint
        verbose: true
        args:
          - --color
          - --fix
        exclude: auth_jwt_demo/tests/spa/js/oidc-client.esm.js

let's try like this to speed up migrations 😃

[sbidoul]

There is already a // prettier-ignore directive in that file. I don't know why eslint complains and did not in v13, but I'd rather have a directive in the file that an exclude in the pre-commit-config, since we strive a getting the pre-commit-config identical in all repos for easier maintenance.

[yankinmax]

this doesn't work here, any ideas?
I tried also:
/* eslint-disable-line */
/* eslint-disable-next-line */

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[simahawk]

@yankinmax any update?

[yankinmax]

@simahawk I couldn't solve pre-commit issues.
#316 (comment)

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[yankinmax]

Superseded by:

• [15.0][MIG] auth_jwt: Migration to 15.0 #622