Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][14.0] Authentication Show Hide Password #636

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

FrancescoBallerini
Copy link

Add buttons to hide/show password in login, signup and reset password form. It seems like an useful missing functionality to add in OCA.

I have found some free modules doing this in the odoo app store but they all use replace xpath attributes on password inputs.

This implementation is a bit more verbose but avoid using replace on pw inputs.

@FrancescoBallerini
Copy link
Author

I have just realized by testing on runbot that this has some incompatibility with the "password meter" element introduced in signup by module auth_password_policy_signup.

I will work on a solution to this.

Add buttons to hide/show password in login, signup and reset password form.
@FrancescoBallerini
Copy link
Author

Update:

  • added some basic scss to avoid "password meter" element to overlap with the "show password" button
  • added compatibility with Edge: the browser will display its own button, we disable the feature in extended form in order to avoid redundant buttons while this modue is installed

The only "issue" remaining is the fact that the "password meter" item will temporary disappear while user focuses the "password" input (see images)

Input Password has focus (password meter disappear)

Screenshot 2024-04-14 162000

Move focus to another element (password meter appear again)

Screenshot 2024-04-14 161948

I have made an attempt to solve this last one (you can find it on scss file) but I didn't manage to solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant