[16.0][FIX] vault: Secret generator is not saving new value #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a field has assigned a value and we try to change it by using the secrets generator, the new value is not saved. It is happening because the click event on wizard buttons is propagated and this trigger the bus event RELATIONAL_MODEL:NEED_LOCAL_CHANGES. By doing this changes the value generated is assigned to the field without loosing the focus. So the value is saved. Steps to reproduce the problem: 1. Create a Vault 2. Create an Entry for the Vault 3. Create a Field for the Entry 4. Assign a value 5. Edit the value using the button to generate secrets 6. Save the new secret You will see that the value salected on wizard is not saved. TT49554
pedrobaeza
approved these changes
Jun 10, 2024
fkantelberg
approved these changes
Jun 10, 2024
victoralmau
approved these changes
Jun 11, 2024
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at caf6a89. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a field has assigned a value and we try to change it by using the secrets generator, the new value is not saved. It is happening because the click event on wizard buttons is propagated and this trigger the bus event RELATIONAL_MODEL:NEED_LOCAL_CHANGES.
By doing this changes the value generated is assigned to the field without loosing the focus. So the value is saved.
Steps to reproduce the problem:
You will see that the value salected on wizard is not saved.
cc @Tecnativa TT49554
ping @victoralmau @pedrobaeza @fkantelberg