[16.0][FIX] auth_saml: update signin method #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the signin method to reflect changes in similar method signin from auth_oauth. Without the changes, the ORM crashes with psycopg2.errors.InvalidSavepointSpecification when trying to signin. Fixes OCA#664
vincent-hatakeyama
force-pushed
the
16.0-auth_saml-fix
branch
from
39b4f2f
to
8b610ca
Compare
vincent-hatakeyama
changed the title
|
/ocabot rebase patch |
|
Hi @vincent-hatakeyama. Your command failed:
Ocabot commands
More information
|
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 9039dcb. Thanks a lot for contributing to OCA. ❤️ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the signin method to reflect changes in similar method signin from auth_oauth.
Without the changes, the ORM crashes with psycopg2.errors.InvalidSavepointSpecification when trying to signin.
Fixes #664