12.0 mig base_dav #141

cesarlr · 2021-12-29T17:12:05Z

No description provided.

cesarlr · 2021-12-30T11:04:06Z

@hbrunn @fkantelberg What do you think? Ready to merge?

fkantelberg

Sadly I can't test it currently. But as far as I remember the only problem was that the datetime fields changed from str to datetime objects between v11 and v12. I see that you have provided a fix there but it could be written simpler.

base_dav/models/dav_collection.py

hbrunn

you'll need to increase coverage for this to be mergeable.

I'd also suggest to update to the 3.x branch of radicale: https://radicale.org/v3.html

Co-authored-by: Yannick Vaucher <yannick.vaucher@camptocamp.com>

cesarlr · 2022-03-31T15:47:03Z

you'll need to increase coverage for this to be mergeable.

I'd also suggest to update to the 3.x branch of radicale: https://radicale.org/v3.html

Radicale v3 needs Python 3.6. I have had to change Python version in Travis CI because in repo it's 3.5. I don't know if it is a good idea...

oyale · 2022-04-04T17:47:36Z

base_dav/controllers/main.py

+                config.set(section, key, data["value"])
+        config.set('auth', 'type', 'odoo.addons.base_dav.radicale.auth')
+        config.set(
+            'storage', 'type', 'odoo.addons.base_dav.radicale.collection'


It looks like we have to define the Storage class in radicale/collection.py and implement the BaseStorage methods from radicale.storage if we want to change the default values.

Otherwise, we can remove this line as the L36 loop will set the default values.

I am getting a permission error while creating directories in the default path (/var/lib/radicale).

base_dav/tests/test_base_dav.py

oyale · 2022-04-04T18:27:56Z

base_dav/radicale/rights.py

+class Rights(OwnerOnlyRights, OwnerWriteRights, AuthenticatedRights):
+    def authorization(self, user, path):
+        if path == '/':
+            return True


Suggested change

return True

return ""

This method must return granted rights (e.g. "RW"), not a boolean.

base_dav/radicale/rights.py

oyale · 2022-04-04T18:28:20Z

base_dav/radicale/rights.py

+            "authenticated": AuthenticatedRights,
+        }.get(rights)
+        if not cls:
+            return False


Suggested change

return False

return ""

base_dav/controllers/main.py

oyale

This will cause an error (3 instead 2 positional arguments)

base_dav/controllers/main.py

diggy128 · 2022-04-27T05:37:34Z

Anything I can do to help speed this up?
Merp from Xpansa fails to sync contacts and calendar on Android and it is essential in for implementation.

oyale · 2022-05-03T07:23:04Z

Anything I can do to help speed this up? Merp from Xpansa fails to sync contacts and calendar on Android and it is essential in for implementation.

Hi @diggy128! Thanks for asking.

We need to improve code coverage to migrate the add-on into v12. Could you help us with that?

diggy128 · 2022-05-08T19:48:48Z

Hi @oyale
Writing tests is not my strong point and this time of the year I'm very time stressed but I could find some time eventually to chip in.

On the other hand, I downloaded the PR and I have come up with a lot of problems. It even seems that the module doesn't work at all.

Maybe we should look on that first or have I done something completely wrong that broke my installation?
I'll put some comments on the code to give you an insight.

oyale · 2022-06-02T14:24:43Z

Hi @oyale Writing tests is not my strong point and this time of the year I'm very time stressed but I could find some time eventually to chip in.
Maybe we should look on that first or have I done something completely wrong that broke my installation? I'll put some comments on the code to give you an insight.

You're absolutelly right.

Sadly, we've run out of time for this issue this term. Any insights would be greatly appreciated.

github-actions · 2022-10-02T12:21:23Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

huguesdk · 2023-07-10T21:49:38Z

i’ve done the porting to 12.0 independently in #226 and discovered this pr only after that. in that pr i’ve only ported the code to work with odoo 12, without upgrading to radicale 3. i propose to make the module already available in 12 in its current state, so that it can already be used. i think that the port to radicale 3 should be handled in a separate subsequent pr, as it is not directly linked to the porting to odoo 12. what do you think?

oyale · 2023-07-12T12:10:57Z

I agree that handling the migration to radicale 3 in a separate PR would allow to use the module now and also, it is not a requirement to port it to odoo 12.

diggy128 · 2023-07-12T17:58:54Z

Same thing here. Having a module that works, even with a bit of outdated dependency is better than no module at all.

huguesdk · 2023-07-12T18:02:10Z

thanks for your answers. feel free to review #226 so that it can be merged quickly.

cesarlr force-pushed the 12.0-mig-base-dav branch from 9fa5f65 to d4209d6 Compare December 29, 2021 17:29

fkantelberg suggested changes Jan 1, 2022

View reviewed changes

base_dav/models/dav_collection.py Outdated Show resolved Hide resolved

hbrunn requested changes Jan 2, 2022

View reviewed changes

cesarlr force-pushed the 12.0-mig-base-dav branch from f0d2b60 to ff82a56 Compare March 31, 2022 15:32

hbrunn and others added 9 commits March 31, 2022 17:33

[ADD] base_dav

e0e06ff

Fix CI errors

0e2493d

Mute radicale logger for testing

0eabcc6

Use the collection as first argument in the creation of the items

6e6331c

Use related model_id field to build domain

d4136bc

Set default id for fields

63b7f19

Co-authored-by: Yannick Vaucher <yannick.vaucher@camptocamp.com>

Add missing quotation

27f7788

[UPD] Update base_dav.pot

3d9eb10

[UPD] README.rst

b595122

cesarlr force-pushed the 12.0-mig-base-dav branch from ff82a56 to 1b233f9 Compare March 31, 2022 15:33

cesarlr force-pushed the 12.0-mig-base-dav branch from 444fbcd to e669594 Compare April 1, 2022 16:36

oyale suggested changes Apr 4, 2022

View reviewed changes

oyale reviewed Apr 4, 2022

View reviewed changes

base_dav/controllers/main.py Outdated Show resolved Hide resolved

oyale suggested changes Apr 4, 2022

View reviewed changes

base_dav/controllers/main.py Outdated Show resolved Hide resolved

cesarlr marked this pull request as draft April 8, 2022 16:06

cesarlr force-pushed the 12.0-mig-base-dav branch 2 times, most recently from 971ce14 to 5b4443b Compare April 19, 2022 16:30

[MIG] base_dav: Migration to 12.0

9f52449

cesarlr force-pushed the 12.0-mig-base-dav branch from 5b4443b to 9f52449 Compare April 21, 2022 07:22

Merge branch '12.0' into 12.0-mig-base-dav

ea66bbb

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 2, 2022

github-actions bot closed this Nov 6, 2022

huguesdk mentioned this pull request Jul 6, 2023

[12.0][MIG] base_dav: migration to 12.0 #226

Open

fkantelberg mentioned this pull request Nov 1, 2023

Migration to version 16.0 #184

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12.0 mig base_dav #141

12.0 mig base_dav #141

cesarlr commented Dec 29, 2021

cesarlr commented Dec 30, 2021

fkantelberg left a comment

hbrunn left a comment

cesarlr commented Mar 31, 2022

oyale Apr 4, 2022 •

edited

Loading

oyale Apr 4, 2022

oyale Apr 4, 2022

oyale Apr 4, 2022

oyale left a comment

diggy128 commented Apr 27, 2022

oyale commented May 3, 2022

diggy128 commented May 8, 2022

oyale commented Jun 2, 2022

github-actions bot commented Oct 2, 2022

huguesdk commented Jul 10, 2023

oyale commented Jul 12, 2023

diggy128 commented Jul 12, 2023

huguesdk commented Jul 12, 2023

12.0 mig base_dav #141

12.0 mig base_dav #141

Conversation

cesarlr commented Dec 29, 2021

cesarlr commented Dec 30, 2021

fkantelberg left a comment

Choose a reason for hiding this comment

hbrunn left a comment

Choose a reason for hiding this comment

cesarlr commented Mar 31, 2022

oyale Apr 4, 2022 • edited Loading

Choose a reason for hiding this comment

oyale Apr 4, 2022

Choose a reason for hiding this comment

oyale Apr 4, 2022

Choose a reason for hiding this comment

oyale Apr 4, 2022

Choose a reason for hiding this comment

oyale left a comment

Choose a reason for hiding this comment

diggy128 commented Apr 27, 2022

oyale commented May 3, 2022

diggy128 commented May 8, 2022

oyale commented Jun 2, 2022

github-actions bot commented Oct 2, 2022

huguesdk commented Jul 10, 2023

oyale commented Jul 12, 2023

diggy128 commented Jul 12, 2023

huguesdk commented Jul 12, 2023

oyale Apr 4, 2022 •

edited

Loading