-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.0 mig base_dav #141
12.0 mig base_dav #141
Conversation
9fa5f65
to
d4209d6
Compare
@hbrunn @fkantelberg What do you think? Ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly I can't test it currently. But as far as I remember the only problem was that the datetime fields changed from str to datetime objects between v11 and v12. I see that you have provided a fix there but it could be written simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to increase coverage for this to be mergeable.
I'd also suggest to update to the 3.x branch of radicale: https://radicale.org/v3.html
f0d2b60
to
ff82a56
Compare
Co-authored-by: Yannick Vaucher <yannick.vaucher@camptocamp.com>
ff82a56
to
1b233f9
Compare
Radicale v3 needs Python 3.6. I have had to change Python version in Travis CI because in repo it's 3.5. I don't know if it is a good idea... |
444fbcd
to
e669594
Compare
config.set(section, key, data["value"]) | ||
config.set('auth', 'type', 'odoo.addons.base_dav.radicale.auth') | ||
config.set( | ||
'storage', 'type', 'odoo.addons.base_dav.radicale.collection' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we have to define the Storage
class in radicale/collection.py and implement the BaseStorage
methods from radicale.storage
if we want to change the default values.
Otherwise, we can remove this line as the L36 loop will set the default values.
I am getting a permission error while creating directories in the default path (/var/lib/radicale
).
class Rights(OwnerOnlyRights, OwnerWriteRights, AuthenticatedRights): | ||
def authorization(self, user, path): | ||
if path == '/': | ||
return True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return True | |
return "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method must return granted rights (e.g. "RW"
), not a boolean.
"authenticated": AuthenticatedRights, | ||
}.get(rights) | ||
if not cls: | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return False | |
return "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause an error (3 instead 2 positional arguments)
971ce14
to
5b4443b
Compare
5b4443b
to
9f52449
Compare
Anything I can do to help speed this up? |
Hi @diggy128! Thanks for asking. We need to improve code coverage to migrate the add-on into v12. Could you help us with that? |
Hi @oyale On the other hand, I downloaded the PR and I have come up with a lot of problems. It even seems that the module doesn't work at all. Maybe we should look on that first or have I done something completely wrong that broke my installation? |
You're absolutelly right. Sadly, we've run out of time for this issue this term. Any insights would be greatly appreciated. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
i’ve done the porting to 12.0 independently in #226 and discovered this pr only after that. in that pr i’ve only ported the code to work with odoo 12, without upgrading to radicale 3. i propose to make the module already available in 12 in its current state, so that it can already be used. i think that the port to radicale 3 should be handled in a separate subsequent pr, as it is not directly linked to the porting to odoo 12. what do you think? |
I agree that handling the migration to radicale 3 in a separate PR would allow to use the module now and also, it is not a requirement to port it to odoo 12. |
Same thing here. Having a module that works, even with a bit of outdated dependency is better than no module at all. |
thanks for your answers. feel free to review #226 so that it can be merged quickly. |
No description provided.