Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.0 mig base user role #15

Merged
merged 13 commits into from
Nov 19, 2018
Merged

12.0 mig base user role #15

merged 13 commits into from
Nov 19, 2018

Conversation

novawish
Copy link

@novawish novawish commented Oct 14, 2018 •
edited
Loading

Credits to @jcdrubay

@pedrobaeza pedrobaeza added this to the 12.0 milestone Oct 14, 2018
@pedrobaeza
Copy link
Member

Can you check Travis and runbot status?

@novawish novawish force-pushed the 12.0-mig-base_user_role branch 2 times, most recently from 3d0bf02 to f279271 Compare November 12, 2018 11:49
@novawish
Copy link
Author

I fixed runbot, however i don't know the reason why travis is failed, do you have any idea?
image

Thanks

@sebalix
Copy link
Contributor

sebalix commented Nov 13, 2018

We should upgrade to PostgreSQL 9.5 (currently the 9.3 is used), ON CONFLICT syntax seems to be available only on 9.5. Try to change the version in .travis.yml file.

@novawish
Copy link
Author

@sebalix Thank you very much, i updated pg version in .travis.yml to 9.5
@pedrobaeza Runbot and travis is ok now

sebalix
sebalix requested changes Nov 13, 2018
View reviewed changes
base_user_role/__manifest__.py Outdated Show resolved Hide resolved
base_user_role/__manifest__.py Outdated Show resolved Hide resolved
HaraldPanten
HaraldPanten approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Is it ready to merge?

THX!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot mentioned this pull request Nov 19, 2018
Closed
9 tasks
sebalix and others added 13 commits November 19, 2018 17:59
@sebalix @pedrobaeza
8.0 - New module 'base_user_role' to manage user roles efficiently (#…
e0daffb 
…608)

* [ADD] New module 'base_user_role'

* [FIX] base_user_role - Review

* [FIX] base_user_role - Review s/is_active/is_enabled/

* [FIX] base_user_role - Review s/is_active/is_enabled/

* [IMP] base_user_role - Translations updated (template + FR)

* [FIX] base_user_role - Lint
@sbidoul @pedrobaeza
base_user_role: display roles as first tab in user form
d7732a5
@sebalix @pedrobaeza
base_user_role - Set a default category to associated groups
195a958
@adrienpeiffer @pedrobaeza
[MIG] base_user_role: Port to 10.0
439d324
@alexis-via @pedrobaeza
[FIX] Crash in base_user_role when role_id is not set on res.users.ro…
44a20fc 
…le.line
@benwillig @pedrobaeza
[10.0][FIX] User group not updating when removing a user from the rol…
0360967 
…e view
@pedrobaeza
[MIG] base_user_role: Migration to 11.0
e63b030
@sebalix @pedrobaeza
[FIX+IMP] base_user_role: Several things:
48703df 
* FIX: Update users' groups when a role is deleted
* IMP: add some test cases to check user's groups when its last role line is removed
* FIX: ensure that the user's groups are updated when its last role line is removed
@pedrobaeza
[MIG] Update test cases for testing (unlink role and role line) to ne…
1f51952 
…w api
@benwillig @pedrobaeza
[IMP] Use default user to define default roles to create for a new user
dcc76bd
@oca-travis @pedrobaeza
[UPD] Update base_user_role.pot
287070f
@hhgabelgaard @pedrobaeza
Translated using Weblate (Danish)
4f87436 
Currently translated at 100,0% (37 of 37 strings)

Translation: server-backend-11.0/server-backend-11.0-base_user_role
Translate-URL: https://translation.odoo-community.org/projects/server-backend-11-0/server-backend-11-0-base_user_role/da/
@pedrobaeza
[MIG] base_user_role: Migration to 12.0
a34fb2e
@oca-clabot
Copy link

Hey @novawish, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@pedrobaeza pedrobaeza merged commit c0a3bfa into OCA:12.0 Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet