-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG]base_external_dbsource #208
[16.0][MIG]base_external_dbsource #208
Conversation
(../ext rev 351.3.3)
…sible behaviors (../ext rev 351.3.4)
(../ext rev 366)
…d__ and adopted for instalation on v8.0 : created new form views for both modules as old ones was for v6.1
OCA Transbot updated translations from Transifex
* Migration of base_external_dbsource to odoo 9.0 * Fixing test error * Moving test from yaml to python * Fixing pylint error in test class * Placeholder added to connection string text zone * improving test coverage OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
With the agreement of authors and contributors. Closes #635 (OCA/server-tools#635)
* Heavily refactor code for reusability * Split all sources into independent modules * Add more test coverage * Add CRUD methods * Add iterator execute return to roadmap OCA Transbot updated translations from Transifex
* Use `conn_string_full` in pg connection to fix #888 [UPD] Update base_external_dbsource.pot
[UPD] README.rst [UPD] Update base_external_dbsource.pot
[UPD] README.rst [UPD] Update base_external_dbsource.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/ [UPD] README.rst
Currently translated at 100.0% (34 of 34 strings) Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/pt_BR/
Before, postgres configuration was hardcoded. This worked OK for OCA's CI infrastructure, but failed in any other out there that had different defaults. There's no need to hardcode it; Odoo already must have Postgres connection settings, so let's use those instead. This will make tests testable across different CI infrastructures. base_external_dbsource 12.0.1.0.1 [UPD] Update base_external_dbsource.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/ [UPD] Update base_external_dbsource.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/
[UPD] Update base_external_dbsource.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-13.0/server-backend-13.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-13-0/server-backend-13-0-base_external_dbsource/ pre-commit update Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-13.0/server-backend-13.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-13-0/server-backend-13-0-base_external_dbsource/
…t be tested (it is not possible to test the connection with odoo postgress). base_external_dbsource 14.0.1.0.1
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-15.0/server-backend-15.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-15-0/server-backend-15-0-base_external_dbsource/
Currently translated at 34.4% (10 of 29 strings) Translation: server-backend-15.0/server-backend-15.0-base_external_dbsource Translate-URL: https://translation.odoo-community.org/projects/server-backend-15-0/server-backend-15-0-base_external_dbsource/it/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration looks good. However, please attend that failed CI job ❌.
/ocabot migration base_external_dbsource
fbc8ad4
to
bc8f25b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you! 👍
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
@yajo The merge process could not be finalized, because command
|
Congratulations, your PR was merged at f4e13e3. Thanks a lot for contributing to OCA. ❤️ |
This module allow to connect a external database using ODBC, Firebird, Oracle Client or SQLAlchemy
MT-2672 @moduon @rafaelbn @yajo @Shide please review :)