Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG]base_external_dbsource #208

Merged
merged 30 commits into from
Mar 31, 2023

Conversation

anddago78
Copy link

This module allow to connect a external database using ODBC, Firebird, Oracle Client or SQLAlchemy

MT-2672 @moduon @rafaelbn @yajo @Shide please review :)

webtec and others added 29 commits March 30, 2023 12:05
…d__ and adopted for instalation on v8.0 : created new form views for both modules as old ones was for v6.1
OCA Transbot updated translations from Transifex
* Migration of base_external_dbsource to odoo 9.0

* Fixing test error

* Moving test from yaml to python

* Fixing pylint error in test class

* Placeholder added to connection string text zone

* improving test coverage

OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
With the agreement of authors and contributors.
Closes #635 (OCA/server-tools#635)
* Heavily refactor code for reusability
* Split all sources into independent modules
* Add more test coverage
* Add CRUD methods
* Add iterator execute return to roadmap

OCA Transbot updated translations from Transifex
* Use `conn_string_full` in pg connection to fix #888

[UPD] Update base_external_dbsource.pot
[UPD] README.rst

[UPD] Update base_external_dbsource.pot
[UPD] README.rst

[UPD] Update base_external_dbsource.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/

[UPD] README.rst
Currently translated at 100.0% (34 of 34 strings)

Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/pt_BR/
Before, postgres configuration was hardcoded. This worked OK for OCA's CI infrastructure, but failed in any other out there that had different defaults.

There's no need to hardcode it; Odoo already must have Postgres connection settings, so let's use those instead. This will make tests testable across different CI infrastructures.

base_external_dbsource 12.0.1.0.1

[UPD] Update base_external_dbsource.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/

[UPD] Update base_external_dbsource.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-12.0/server-backend-12.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-12-0/server-backend-12-0-base_external_dbsource/
[UPD] Update base_external_dbsource.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-13.0/server-backend-13.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-13-0/server-backend-13-0-base_external_dbsource/

pre-commit update

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-13.0/server-backend-13.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-13-0/server-backend-13-0-base_external_dbsource/
 - problems with tests
 - pre-commit

[UPD] Update base_external_dbsource.pot

[UPD] README.rst
…t be tested (it is not possible to test the connection with odoo postgress).

base_external_dbsource 14.0.1.0.1
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-backend-15.0/server-backend-15.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-15-0/server-backend-15-0-base_external_dbsource/
Currently translated at 34.4% (10 of 29 strings)

Translation: server-backend-15.0/server-backend-15.0-base_external_dbsource
Translate-URL: https://translation.odoo-community.org/projects/server-backend-15-0/server-backend-15-0-base_external_dbsource/it/
@yajo yajo added the migration label Mar 31, 2023
@yajo yajo added this to the 16.0 milestone Mar 31, 2023
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration looks good. However, please attend that failed CI job ❌.

/ocabot migration base_external_dbsource

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 31, 2023
11 tasks
@anddago78 anddago78 force-pushed the 16.0-mig-base_external_dbsource branch from fbc8ad4 to bc8f25b Compare March 31, 2023 10:08
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you! 👍

@yajo
Copy link
Member

yajo commented Mar 31, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-208-by-yajo-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@yajo The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-208-by-yajo-bump-patch:16.0 failed with output:

To https://github.com/OCA/server-backend
 ! [rejected]        16.0-ocabot-merge-pr-208-by-yajo-bump-patch -> 16.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/server-backend'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

@OCA-git-bot OCA-git-bot merged commit 88f627e into OCA:16.0 Mar 31, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f4e13e3. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-mig-base_external_dbsource branch April 5, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet