11.0 mig disable odoo online #1

hieulucky111 · 2017-11-23T05:01:43Z

No description provided.

pedrobaeza · 2017-12-05T20:53:26Z

disable_odoo_online/views/ir_ui_menu.xml

+<odoo>
+
+    <!-- Menus moved under Tools\Parameters --> 
+    <record model="ir.ui.menu" id="base.module_mi">


This is something unrelated to the module.

pedrobaeza · 2017-12-05T20:53:49Z

disable_odoo_online/README.rst

+* update notifier code is deactivated and the function is overwritten
+* apps and updates menu items in settings are hidden inside Technical \\Parameters
+
+Installation


Remove this section

pedrobaeza · 2017-12-05T20:54:01Z

disable_odoo_online/data/ir_cron.xml

+<odoo>
+
+    <record id="mail.ir_cron_module_update_notification" model="ir.cron">
+        <field name="active" eval="False" />


What this does?

This used to deactivate function update_notification in module mail. Function update_notification used to "Send a message to Odoo's publisher warranty server to check the validity of the contracts, get notifications, etc...".

Hmmmm I thought we had to leave this active, and instead disabled it in PublisherWarrantyContract.update_notification. Am I remembering incorrectly @legalsylvain?

lasley

Thanks @hieulucky111 - few minor comments inline

lasley · 2017-12-15T19:14:34Z

disable_odoo_online/README.rst

+   :target: https://www.gnu.org/licenses/agpl
+   :alt: License: AGPL-3
+
+==================


Please extend the = to the end of the header

lasley · 2017-12-15T19:14:42Z

disable_odoo_online/README.rst

+===========
+
+Bugs are tracked on `GitHub Issues
+<https://github.com/OCA/server-tools/issues>`_. In case of trouble, please


lasley · 2017-12-15T19:18:02Z

disable_odoo_online/data/ir_cron.xml

+<odoo>
+
+    <record id="mail.ir_cron_module_update_notification" model="ir.cron">
+        <field name="active" eval="False" />


Hmmmm I thought we had to leave this active, and instead disabled it in PublisherWarrantyContract.update_notification. Am I remembering incorrectly @legalsylvain?

lasley · 2017-12-15T19:18:25Z

disable_odoo_online/models/publisher_warranty_contract.py

+
+    @api.multi
+    def update_notification(self, cron_mode=True):
+        if version_info[5] == 'e':


PublisherWarrantyContract

Can you explain more?

I honestly don't remember. Let's just assume I was being dumb!

lasley

Thanks @hieulucky111

astirpe

We already use this module in production and it works fine!
I just have one question, for the rest this module is ok.

astirpe · 2018-01-17T16:49:04Z

disable_odoo_online/data/ir_cron.xml

+<odoo>
+
+    <record id="mail.ir_cron_module_update_notification" model="ir.cron">
+        <field name="active" eval="True" />


OK let's say (as @lasley said) that active should be True. But then my question is: why do we keep this line? What about removing the entire ir_cron.xml file?

Looks to me like this logic was here before we realized that we were not allowed to disable the update notification for EE. Tracing it into the code, this cron does call update_notification.

In this light, I think we've broken contract for anyone that has this installed on EE

Example: if someone decides to disable manually this cron for some reason, we are forcing it to set to active=True again as soon as he installs this module (or makes an update all, for example). There is not even set odoo noupdate="1" in the actual solution. It's still not clear to me, sorry.

@hbrunn - you wrote this one, do you remember?

my version of this was disabling it: https://github.com/OCA/server-tools/blob/10.0/disable_odoo_online/data/ir_cron.xml#L5 - so yes, whoever noticed this shouldn't be done any more should have just ditched the file. check the commit history. speaking of which, you shouldn't approve PRs which don't take the commit history with them, especially for cases like the current one, it's utterly annoying having to puzzle together the evolution of a module/file if the link is cut

Clear, thank you!
@hieulucky111 can you please remove the ir_cron.xml file?

pedrobaeza · 2018-01-18T07:45:34Z

@hieulucky111 can you redo commit history following migration guide?

astirpe · 2018-02-19T10:49:56Z

@pedrobaeza is it ok to merge this one?

yajo · 2018-02-20T08:38:49Z

disable_odoo_online/__manifest__.py

+    "license": "AGPL-3",
+    "category": "base",
+    "depends": [
+        'base',


No need to depend on base if you depend on other things.

njeudy

Code check and test

…. Update the version in the file __openerp__.py

…n. (#583) * [PORT] disable_odoo_online. [REF] remove obsolete code. OCA convention. * [FIX] restauring old feature * [IMP] do not disable some feature for Enterprise Edition. [REF] some improvements

hieulucky111 mentioned this pull request Nov 23, 2017

11.0 mig disable odoo online OCA/server-tools#1042

Closed

pedrobaeza requested changes Dec 5, 2017

View reviewed changes

lasley suggested changes Dec 15, 2017

View reviewed changes

This was referenced Dec 21, 2017

Migration to version 11.0 OCA/server-tools#1008

Closed

11.0 mig disable odoo online OCA/server-tools#1100

Closed

lasley approved these changes Jan 17, 2018

View reviewed changes

lasley added this to the 11.0 milestone Jan 17, 2018

lasley added the needs review label Jan 17, 2018

astirpe suggested changes Jan 17, 2018

View reviewed changes

hieulucky111 force-pushed the 11.0-mig-disable_odoo_online branch from 9492ca0 to e24daf9 Compare January 19, 2018 04:15

astirpe approved these changes Jan 25, 2018

View reviewed changes

yajo reviewed Feb 20, 2018

View reviewed changes

hieulucky111 force-pushed the 11.0-mig-disable_odoo_online branch from e24daf9 to 16d3299 Compare February 28, 2018 11:34

JordiBForgeFlow mentioned this pull request Mar 7, 2018

11.0 revision ForgeFlow/sample-oca-pip-requirements#4

Merged

njeudy approved these changes Mar 23, 2018

View reviewed changes

tungocbui and others added 3 commits March 23, 2018 18:51

[FIX] Rename the module disable_openerp_online to disable_odoo_online…

c10e675

…. Update the version in the file __openerp__.py

[PORT] disable_odoo_online. [REF] remove obsolete code. OCA conventio…

bf21972

…n. (#583) * [PORT] disable_odoo_online. [REF] remove obsolete code. OCA convention. * [FIX] restauring old feature * [IMP] do not disable some feature for Enterprise Edition. [REF] some improvements

[MIG] Disable_odoo_online: Migration to 11.0

9d59892

pedrobaeza force-pushed the 11.0-mig-disable_odoo_online branch from 16d3299 to 9d59892 Compare March 23, 2018 17:52

pedrobaeza approved these changes Mar 23, 2018

View reviewed changes

pedrobaeza merged commit 809b8df into OCA:11.0 Mar 23, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

11.0 mig disable odoo online #1

11.0 mig disable odoo online #1

hieulucky111 commented Nov 23, 2017

pedrobaeza Dec 5, 2017

pedrobaeza Dec 5, 2017

pedrobaeza Dec 5, 2017

hieulucky111 Dec 13, 2017

lasley Dec 15, 2017

lasley left a comment

lasley Dec 15, 2017

lasley Dec 15, 2017

lasley Dec 15, 2017

lasley Dec 15, 2017

hieulucky111 Jan 17, 2018

lasley Jan 17, 2018

lasley left a comment

astirpe left a comment

astirpe Jan 17, 2018

lasley Jan 17, 2018

astirpe Jan 17, 2018 •

edited

lasley Jan 17, 2018

hbrunn Jan 18, 2018

astirpe Jan 18, 2018

pedrobaeza commented Jan 18, 2018

astirpe commented Feb 19, 2018

yajo Feb 20, 2018

njeudy left a comment

11.0 mig disable odoo online #1

11.0 mig disable odoo online #1

Conversation

hieulucky111 commented Nov 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley left a comment

Choose a reason for hiding this comment

astirpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astirpe Jan 17, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jan 18, 2018

astirpe commented Feb 19, 2018

Choose a reason for hiding this comment

njeudy left a comment

Choose a reason for hiding this comment

astirpe Jan 17, 2018 •

edited